[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
editorconfig makes advice
From:
Richard Stallman
Subject:
editorconfig makes advice
Date:
2024年6月21日 22:47:19 -0400
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
I was looking at the posted diffs and saw this:
(advice-add 'find-file-noselect :around
#'editorconfig--advice-find-file-noselect)
- (advice-add 'insert-file-contents :around
#'editorconfig--advice-insert-file-contents)
+ (advice-add 'find-auto-coding :after-until
+ #'editorconfig--advice-find-auto-coding)
Our general design principle is that parts of Emacs should not advise other
parts of Emacs -- instead, they should set up hooks that the other parts run.
The reasons for this are documented.
Is there a rpecial reason to use advice here? If not,
can we please eliminate this advice, perhaps by making a few new hooks?
--
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
- editorconfig makes advice,
Richard Stallman <=