Re: URGENT - which-key FSF contributor status

emacs-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: URGENT - which-key FSF contributor status

From: Eli Zaretskii

Subject: Re: URGENT - which-key FSF contributor status

Date: 2024年6月18日 20:37:41 +0300

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: jb@jeremybryant.net, justin@burkett.cc, emacs-devel@gnu.org
> Date: 2024年6月18日 08:49:47 +0000
>
> >> The :version tags of the defcustoms and deffaces will need to change.
> >
> > I can change the current tags to :package-version and also add :version
> > "30.1" tags.
>
> This has been done.
>
> >> Some faces use attributes such as underline or bold without testing
> >> for their availability first and without offering any fallbacks if
> >> they aren't. Is it okay to have those displayed using the default
> >> face?
> >
> > My guess is that this is just decoration, but someone who actually uses
> > which-key should comment on that. Specifically it appears to involve
> > the
> >
> > - which-key-special-key-face
> > - which-key-highlighted-command-face
>
> I think that it should be OK for 'which-key-special-key-face' to use
> :bold, because it is accompanied by :inverse-video that carries most of
> the visual effect.
>
> As for 'which-key-highlighted-command-face', I have removed the
> :underline and instead let it inherit from 'highlight'. I hope nobody
> objects to that. By default it doesn't make any difference, as it only
> affects people who have customised 'which-key-highlighted-command-list'.
>
> IMO we could merge the branch into master.
Thanks, I think it's okay to land this on master.

[Prev in Thread] Current Thread [Next in Thread]

Re: URGENT - which-key FSF contributor status, (continued)

Prev by Date: Re: MPS: Forwording symbols
Next by Date: Re: pkg-autoloads.el vs. pkg-loaddefs.el
Previous by thread: Re: URGENT - which-key FSF contributor status
Next by thread: Re: URGENT - which-key FSF contributor status
Index(es):
- Date
- Thread