emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Shell quoting in Eshell (was: eshell-batch-file)


From: Eli Zaretskii
Subject: Re: Shell quoting in Eshell (was: eshell-batch-file)
Date: 2024年6月16日 08:21:02 +0300

> Date: 2024年6月15日 13:06:53 -0700
> Cc: emacs-devel@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 6/15/2024 12:10 PM, Eli Zaretskii wrote:
> > Test esh-cmd-test/which/plain/external-program condition:
> [snip]
> > :value nil :explanation
> > (nonequal-result (command "which sh")
> > (result #("D:/usr/MSYS/bin/sh.exe\n" 22 23 ...))
> > (expected "d:/usr/MSYS/bin/sh.exe\n"))))
> > FAILED 59/66 esh-cmd-test/which/plain/external-program (0.003953 
> > sec) at lisp/eshell/esh-cmd-tests.el:538
> > 
> > IOW: you run "which SOMETHING" and pretend to know how it will
> > capitalize the drive letter.
>
> Ah ha! If that's the only failure, then I think this would work? (If 
> there are other failures, then I could add a PREDICATE argument to 
> 'eshell-command-result-equal' and use that in the necessary places.)
It works with that change, yes. But please add a comment there
explaining why this is done. Since the fix targets a single command,
it can be described in more detail.
Thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]

AltStyle によって変換されたページ (->オリジナル) /