emacs-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bookmark.el and lisp/gnus/gnus-bookmark.el

From: Stefan Monnier
Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el
Date: 2008年3月08日 18:20:30 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) 
>>> If we get rid of the annotation argument for this single function, it
>>> means the annotation has to be done before this function returns sth
>>> that can be used as the suggested name for the bookmark. 
>> 
>> AFAICT getting rid of the annotation argument means nothing at all,
>> other than that the annotation will have to be added by the generic
>> bookmark-set code rather than being done by every single
>> bookmark-make-record-function.
> For now `bookmark-set' asks for an annotation (if required), sends it to
> `bookmark-make' which calls `bookmark-make-record-function' with the
> annotation as an argument.
> IIUC Tassilo suggested that the annotation should be directly handled by
> `bookmark-make-record-function', which seems correct to me. What you
> propose is to handle annotation in `bookmark-set' (or preferrably in
> `bookmark-make') -- this is _feasible_, but it looks weird to me since
> the annotation is really part of the record.
The record has various parts: a name to select it, an annotation,
a bunch of data to find the place, there could be more (date the record
was created, when it was last used, ...).
The bookmark-make-record-function should only concern itself with
providing the data to find the place. It may also provide a default
name, a default annotation, ... but it's better if it doesn't need to
handle annotations since those are (or rather should be) handled
identically for *all* bookmark-make-record-function.
 Stefan
reply via email to
[Prev in Thread] Current Thread [Next in Thread]

AltStyle によって変換されたページ (->オリジナル) /