[PATCH v5 06/11] imx-drm: imx-tve: Fix DDC I2C bus property

Thu Mar 6 05:03:20 PST 2014

On Wed, Mar 05, 2014 at 10:20:57AM +0100, Philipp Zabel wrote:
> This patch fixes the TV Encoder DDC I2C bus property to use the common
> 'ddc-i2c-bus' property name instead of 'ddc'.

Looking at both hdmi and tve, the ddc part is very similar. The difference
is how the probe is handled:
imx-hdmi:
 ddc_node = of_parse_phandle(np, "ddc", 0);
 if (ddc_node) {
 hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
 if (!hdmi->ddc)
 dev_dbg(hdmi->dev, "failed to read ddc node\n");
 of_node_put(ddc_node);
 } else {
 dev_dbg(hdmi->dev, "no ddc property found\n");
 }
imx-tve:
 ddc_node = of_parse_phandle(np, "ddc", 0);
 if (ddc_node) {
 tve->ddc = of_find_i2c_adapter_by_node(ddc_node);
 of_node_put(ddc_node);
 }
It appears to differ only by debug prints - is there any reason we
couldn't unify the DDC backend part? I've tinkered with this idea,
and already have a patch, though it needs a little rework.
Any thoughts?
-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.