Commit 607c419

soburiDhruvaG2000

authored and

DhruvaG2000

committed

zephyrCommon: Fix buggy irq handler acquisition

Fix an issue where the reference location for the interrupt handler was a bit mask instead of an index value. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com> [DG: tweaked commit message] Signed-off-by: Dhruva Gole <d-gole@ti.com>

1 parent 25d463a commit 607c419Copy full SHA for 607c419

File tree

1 file changed

-5

lines changed

cores/arduino
- zephyrCommon.cpp

1 file changed

-5

lines changed

`‎cores/arduino/zephyrCommon.cpp‎`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ void setInterruptHandler(pin_size_t pinNumber, voidFuncPtr func)`
`104`	`104`	`struct gpio_port_callback *pcb = find_gpio_port_callback(arduino_pins[pinNumber].port);`
`105`	`105`
`106`	`106`	`if (pcb) {`
`107`		`- pcb->handlers[BIT(arduino_pins[pinNumber].pin)].handler = func;`
	`107`	`+ pcb->handlers[arduino_pins[pinNumber].pin].handler = func;`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`
`@@ -113,8 +113,8 @@ void handleGpioCallback(const struct device port, struct gpio_callback cb, uin`
`113`	`113`	`struct gpio_port_callback pcb = (struct gpio_port_callback )cb;`
`114`	`114`
`115`	`115`	`for (uint32_t i = 0; i < max_ngpios; i++) {`
`116`		`- if (pins & BIT(i) && pcb->handlers[BIT(i)].enabled) {`
`117`		`- pcb->handlers[BIT(i)].handler();`
	`116`	`+ if (pins & BIT(i) && pcb->handlers[i].enabled) {`
	`117`	`+ pcb->handlers[i].handler();`
`118`	`118`	`}`
`119`	`119`	`}`
`120`	`120`	`}`
`@@ -453,15 +453,15 @@ void enableInterrupt(pin_size_t pinNumber) {`
`453`	`453`	`struct gpio_port_callback *pcb = find_gpio_port_callback(arduino_pins[pinNumber].port);`
`454`	`454`
`455`	`455`	`if (pcb) {`
`456`		`- pcb->handlers[BIT(arduino_pins[pinNumber].pin)].enabled = true;`
	`456`	`+ pcb->handlers[arduino_pins[pinNumber].pin].enabled = true;`
`457`	`457`	`}`
`458`	`458`	`}`
`459`	`459`
`460`	`460`	`void disableInterrupt(pin_size_t pinNumber) {`
`461`	`461`	`struct gpio_port_callback *pcb = find_gpio_port_callback(arduino_pins[pinNumber].port);`
`462`	`462`
`463`	`463`	`if (pcb) {`
`464`		`- pcb->handlers[BIT(arduino_pins[pinNumber].pin)].enabled = false;`
	`464`	`+ pcb->handlers[arduino_pins[pinNumber].pin].enabled = false;`
`465`	`465`	`}`
`466`	`466`	`}`
`467`	`467`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 607c419

File tree

1 file changed

1 file changed

`‎cores/arduino/zephyrCommon.cpp‎`

0 commit comments