Commit 4b8af7b

liuyanhitliuyanhit

and

liuyanhit

authored

add attrPublishTime, as publishTime must be present for @type='dynamic' (#84)

Co-authored-by: liuyanhit <liuuyan@qiniu.com>

1 parent 70504f6 commit 4b8af7bCopy full SHA for 4b8af7b

File tree

+19

-1

lines changed

+19

-1

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -441,6 +441,8 @@ func NewDynamicMPD(profile DashProfile, availabilityStartTime, minBufferTime str`
`441`	`441`	`mpd.MinimumUpdatePeriod = attr.GetStrptr()`
`442`	`442`	`case *attrMediaPresentationDuration:`
`443`	`443`	`mpd.MediaPresentationDuration = attr.GetStrptr()`
	`444`	`+ case *attrPublishTime:`
	`445`	`+ mpd.PublishTime = attr.GetStrptr()`
`444`	`446`	`}`
`445`	`447`	`}`
`446`	`448`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,3 +42,16 @@ func (attr attrMediaPresentationDuration) GetStrptr() string {`
`42`	`42`	`func AttrMediaPresentationDuration(value string) AttrMPD {`
`43`	`43`	`return &attrMediaPresentationDuration{strptr: &value}`
`44`	`44`	`}`
	`45`	`+`
	`46`	`+type attrPublishTime struct {`
	`47`	`+ strptr *string`
	`48`	`+}`
	`49`	`+`
	`50`	`+func (attr attrPublishTime) GetStrptr() string {`
	`51`	`+ return attr.strptr`
	`52`	`+}`
	`53`	`+`
	`54`	`+// AttrPublishTime returns AttrMPD object for NewMPD`
	`55`	`+func AttrPublishTime(value string) AttrMPD {`
	`56`	`+ return &attrPublishTime{strptr: &value}`
	`57`	`+}`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ const (`
`15`	`15`	`VALID_MEDIA_PRESENTATION_DURATION string = "PT6M16S"`
`16`	`16`	`VALID_MIN_BUFFER_TIME string = "PT1.97S"`
`17`	`17`	`VALID_AVAILABILITY_START_TIME string = "1970年01月01日T00:00:00Z"`
	`18`	`+ VALID_PUBLISH_TIME string = "2020年03月12日T10:39:45Z"`
`18`	`19`	`VALID_MINIMUM_UPDATE_PERIOD string = "PT5S"`
`19`	`20`	`VALID_SCAN_TYPE string = "progressive"`
`20`	`21`	`VALID_SEGMENT_ALIGNMENT bool = true`
`@@ -73,7 +74,8 @@ func TestNewMPDLive(t *testing.T) {`
`73`	`74`	`func TestNewDynamicMPDLive(t *testing.T) {`
`74`	`75`	`m := NewDynamicMPD(DASH_PROFILE_LIVE, VALID_AVAILABILITY_START_TIME, VALID_MIN_BUFFER_TIME,`
`75`	`76`	`AttrMediaPresentationDuration(VALID_MEDIA_PRESENTATION_DURATION),`
`76`		`- AttrMinimumUpdatePeriod(VALID_MINIMUM_UPDATE_PERIOD))`
	`77`	`+ AttrMinimumUpdatePeriod(VALID_MINIMUM_UPDATE_PERIOD),`
	`78`	`+ AttrPublishTime(VALID_PUBLISH_TIME))`
`77`	`79`	`require.NotNil(t, m)`
`78`	`80`	`expectedMPD := &MPD{`
`79`	`81`	`XMLNs: Strptr("urn:mpeg:dash:schema:mpd:2011"),`
`@@ -86,6 +88,7 @@ func TestNewDynamicMPDLive(t *testing.T) {`
`86`	`88`	`period: &Period{},`
`87`	`89`	`Periods: []*Period{{}},`
`88`	`90`	`UTCTiming: &DescriptorType{},`
	`91`	`+ PublishTime: Strptr(VALID_PUBLISH_TIME),`
`89`	`92`	`}`
`90`	`93`
`91`	`94`	`expectedString, err := expectedMPD.WriteToString()`

Comments

(0)