Commit 305d9eb

committed

fix: DOM node key duplicate after switching to virtual list when animation is on

1 parent ec4f63f commit 305d9ebCopy full SHA for 305d9eb

File tree

2 files changed

-4

lines changed

package.json
src/components
- Tree.vue

2 files changed

-4

lines changed

`‎package.json‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@wsfe/ctree",`
`3`		`- "version": "2.4.0",`
	`3`	`+ "version": "2.4.1",`
`4`	`4`	`"main": "./dist/ctree.umd.min.js",`
`5`	`5`	`"types": "./types",`
`6`	`6`	`"description": "A vue tree component using virtual list.",`

`‎src/components/Tree.vue‎`

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -458,6 +458,7 @@ export default (Vue as VueConstructor<Vue & {`
`458`	`458`	`ready: false,`
`459`	`459`	`currentExpandState: false,`
`460`	`460`
	`461`	`+ expandRenderStart: 0,`
`461`	`462`	`topNodes: [] as TreeNode[],`
`462`	`463`	`middleNodes: [] as TreeNode[],`
`463`	`464`	`bottomNodes: [] as TreeNode[],`
`@@ -945,6 +946,7 @@ export default (Vue as VueConstructor<Vue & {`
`945`	`946`	`this.expandAnimation.index = -1`
`946`	`947`	`this.expandAnimation.level = -1`
`947`	`948`
	`949`	`+ this.expandAnimation.expandRenderStart = 0`
`948`	`950`	`this.expandAnimation.topNodes = []`
`949`	`951`	`this.expandAnimation.middleNodes = []`
`950`	`952`	`this.expandAnimation.bottomNodes = []`
`@@ -954,7 +956,8 @@ export default (Vue as VueConstructor<Vue & {`
`954`	`956`	`const nodeToExpandLevel = this.expandAnimation.level`
`955`	`957`	`const middleNodes: TreeNode[] = []`
`956`	`958`	`const renderNodesLength = this.renderNodes.length`
`957`		`- for (let i = this.expandAnimation.index + 1; i < renderNodesLength; i++) {`
	`959`	`+ const expandRenderStartDiff = this.renderStart - this.expandAnimation.expandRenderStart`
	`960`	`+ for (let i = this.expandAnimation.index - expandRenderStartDiff + 1; i < renderNodesLength; i++) {`
`958`	`961`	`if (this.renderNodes[i]._level > nodeToExpandLevel) {`
`959`	`962`	`middleNodes.push(this.renderNodes[i])`
`960`	`963`	`} else break`
`@@ -974,6 +977,7 @@ export default (Vue as VueConstructor<Vue & {`
`974`	`977`	`this.expandAnimation.start = true`
`975`	`978`	`this.expandAnimation.currentExpandState = nodeToExpand.expand`
`976`	`979`	`this.expandAnimation.nextState = !nodeToExpand.expand`
	`980`	`+ this.expandAnimation.expandRenderStart = this.renderStart`
`977`	`981`
`978`	`982`	`if (this.expandAnimation.nextState) {`
`979`	`983`	`this.expandAnimation.bottomNodes = this.renderNodes.slice(this.expandAnimation.index + 1)`
`@@ -994,11 +998,12 @@ export default (Vue as VueConstructor<Vue & {`
`994`	`998`	`if (this.expandAnimation.index === -1) return`
`995`	`999`
`996`	`1000`	`this.$nextTick(() => {`
`997`		`- this.expandAnimation.topNodes = this.renderNodes.slice(0, this.expandAnimation.index + 1)`
	`1001`	`+ const expandRenderStartDiff = this.renderStart - this.expandAnimation.expandRenderStart`
	`1002`	`+ this.expandAnimation.topNodes = this.renderNodes.slice(0, this.expandAnimation.index - expandRenderStartDiff + 1)`
`998`	`1003`	`if (this.expandAnimation.nextState) {`
`999`	`1004`	`this.updateMiddleNodes()`
`1000`	`1005`	`} else {`
`1001`		`- this.expandAnimation.bottomNodes = this.renderNodes.slice(this.expandAnimation.index + 1)`
	`1006`	`+ this.expandAnimation.bottomNodes = this.renderNodes.slice(this.expandAnimation.index -expandRenderStartDiff+ 1)`
`1002`	`1007`	`}`
`1003`	`1008`	`this.expandAnimation.ready = true`
`1004`	`1009`	`this.$nextTick(() => {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 305d9eb

File tree

2 files changed

2 files changed

`‎package.json‎`

`‎src/components/Tree.vue‎`

0 commit comments