Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added helpers/persistenthandler #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ReallyLiri wants to merge 4 commits into willscott:master
base: master
Choose a base branch
Loading
from ReallyLiri:master

Conversation

@ReallyLiri
Copy link

@ReallyLiri ReallyLiri commented Mar 20, 2021
edited
Loading

persistent store is backed by github.com/dgraph-io/badger and is not limited in size

Copy link
Owner

This highlights an aspect of the Handler interface that I'm going to see if I can take a quick pass at improving. Currently Handlers receive a Mount request as a new client connects to the server, but don't have a way to see the subsequent Unmount. In this case, it would be useful to keep track of handles in relation to the associated Mount so that they can be freed once the client Unmount's. Tagging the client can be done by wrapping the billy.Filesystem with an additional struct, but there's currently no way for this handler to know when it's safe to discard handles.

Copy link
Owner

Added the unmount handler method in #28. I'll take a pass at making use of that for freeing handles in this PR later.

liiri reacted with thumbs up emoji

Copy link

Seems to need rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /