Commit ad2ffda

authored

Fix false positives for defineModel in vue/no-undef-properties rule (#2364)

1 parent af7de76 commit ad2ffdaCopy full SHA for ad2ffda

File tree

+11

-15

lines changed

+11

-15

lines changed

Lines changed: 1 addition & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -322,25 +322,12 @@ module.exports = {`
`322`	`322`	`propertyReferenceExtractor.extractFromPattern(pattern)`
`323`	`323`	`ctx.verifyReferences(propertyReferences)`
`324`	`324`	`},`
`325`		`- onDefineModelEnter(node, model) {`
	`325`	`+ onDefineModelEnter(_node, model) {`
`326`	`326`	`const ctx = getVueComponentContext(programNode)`
`327`	`327`
`328`	`328`	`ctx.defineProperties.set(model.name.modelName, {`
`329`	`329`	`isProps: true`
`330`	`330`	`})`
`331`		`-`
`332`		`- if (`
`333`		`- !node.parent \|\|`
`334`		`- node.parent.type !== 'VariableDeclarator' \|\|`
`335`		`- node.parent.init !== node`
`336`		`- ) {`
`337`		`- return`
`338`		`- }`
`339`		`-`
`340`		`- const pattern = node.parent.id`
`341`		`- const propertyReferences =`
`342`		`- propertyReferenceExtractor.extractFromPattern(pattern)`
`343`		`- ctx.verifyReferences(propertyReferences)`
`344`	`331`	`}`
`345`	`332`	`}),`
`346`	`333`	`utils.defineVueVisitor(context, {`

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -558,7 +558,16 @@ tester.run('no-undef-properties', rule, {`
`558`	`558`	`parserOptions: {`
`559`	`559`	`parser: require.resolve('@typescript-eslint/parser')`
`560`	`560`	`}`
`561`		`- }`
	`561`	`+ },`
	`562`	`+`
	`563`	+ `
	`564`	`+ <script setup>`
	`565`	`+ const model = defineModel();`
	`566`	`+ const woof = computed(() => model.value);`
	`567`	`+ </script>`
	`568`	`+ <template>`
	`569`	`+ <div id="app">Woof: {{ woof }}</div>`
	`570`	+ </template>`
`562`	`571`	`],`
`563`	`572`
`564`	`573`	`invalid: [`

Comments

(0)