Commit 8c0399f

committed

Fix: Including custom directives

1 parent 351d9be commit 8c0399fCopy full SHA for 8c0399f

File tree

3 files changed

+22

-15

lines changed

docs/rules
- attributes-order.md
lib/rules
- attributes-order.js
tests/lib/rules
- attributes-order.js

3 files changed

+22

-15

lines changed

`‎docs/rules/attributes-order.md‎`

Lines changed: 16 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ ex: 'ref', 'key', 'slot'`
`20`	`20`	`- TWO\_WAY\_BINDING`
`21`	`21`	`ex: 'v-model'`
`22`	`22`	`- OTHER_ATTR`
`23`		`-ex: 'customProp="foo"'`
	`23`	`+ex: 'custom-prop="foo"', 'v-bind:prop="foo"', ':prop="foo"', 'v-custom-directive'`
`24`	`24`	`- EVENTS`
`25`	`25`	`ex: '@click="functionCall"', 'v-on="event"'`
`26`	`26`	`- CONTENT`
`@@ -37,7 +37,7 @@ ex: 'v-text', 'v-html'`
`37`	`37`	`id="uniqueID"`
`38`	`38`	`ref="header"`
`39`	`39`	`v-model="headerData"`
`40`		`- myProp="prop"`
	`40`	`+ my-prop="prop"`
`41`	`41`	`@click="functionCall"`
`42`	`42`	`v-text="textContent">`
`43`	`43`	`</div>`
`@@ -47,19 +47,19 @@ ex: 'v-text', 'v-html'`
`47`	`47`	`<div`
`48`	`48`	`v-for="item in items"`
`49`	`49`	`v-if="!visible"`
`50`		`- propOne="prop"`
`51`		`- :propTwo="prop"`
`52`		`- propThree="prop"`
	`50`	`+ prop-one="prop"`
	`51`	`+ :prop-two="prop"`
	`52`	`+ prop-three="prop"`
`53`	`53`	`@click="functionCall"`
`54`	`54`	`v-text="textContent">`
`55`	`55`	`</div>`
`56`	`56`	```
`57`	`57`
`58`	`58`	```html
`59`	`59`	`<div`
`60`		`- propOne="prop"`
`61`		`- :propTwo="prop"`
`62`		`- propThree="prop">`
	`60`	`+ prop-one="prop"`
	`61`	`+ :prop-two="prop"`
	`62`	`+ prop-three="prop">`
`63`	`63`	`</div>`
`64`	`64`	```
`65`	`65`
`@@ -69,9 +69,10 @@ ex: 'v-text', 'v-html'`
`69`	`69`	`<div`
`70`	`70`	`ref="header"`
`71`	`71`	`v-for="item in items"`
`72`		`- v-once id="uniqueID"`
	`72`	`+ v-once`
	`73`	`+ id="uniqueID"`
`73`	`74`	`v-model="headerData"`
`74`		`- myProp="prop"`
	`75`	`+ my-prop="prop"`
`75`	`76`	`v-if="!visible"`
`76`	`77`	`is="header"`
`77`	`78`	`@click="functionCall"`
`@@ -88,8 +89,8 @@ Specify custom order of attribute groups`
`88`	`89`	```html
`89`	`90`	`<!-- 'vue/attribute-order': [2, { order: ['LIST_RENDERING', 'CONDITIONALS', 'RENDER_MODIFIERS', 'GLOBAL', 'UNIQUE', 'TWO_WAY_BINDING', 'OTHER_ATTR', 'EVENTS', 'CONTENT', 'DEFINITION'] }] -->`
`90`	`91`	`<div`
`91`		`- propOne="prop"`
`92`		`- propTwo="prop"`
	`92`	`+ prop-one="prop"`
	`93`	`+ prop-two="prop"`
`93`	`94`	`is="header">`
`94`	`95`	`</div>`
`95`	`96`	```
`@@ -99,8 +100,8 @@ Specify custom order of attribute groups`
`99`	`100`	`<div`
`100`	`101`	`ref="header"`
`101`	`102`	`is="header"`
`102`		`- propOne="prop"`
`103`		`- propTwo="prop">`
	`103`	`+ prop-one="prop"`
	`104`	`+ prop-two="prop">`
`104`	`105`	`</div>`
`105`	`106`	```
`106`	`107`
`@@ -110,7 +111,7 @@ Specify custom order of attribute groups`
`110`	`111`	`<!-- 'vue/attribute-order': [2, { order: ['LIST_RENDERING', 'CONDITIONALS', 'RENDER_MODIFIERS', 'GLOBAL', 'UNIQUE', 'TWO_WAY_BINDING', 'DEFINITION', 'OTHER_ATTR', 'EVENTS', 'CONTENT'] }] -->`
`111`	`112`	`<div`
`112`	`113`	`ref="header"`
`113`		`- propOne="prop"`
	`114`	`+ prop-one="prop"`
`114`	`115`	`is="header">`
`115`	`116`	`</div>`
`116`	`117`	```

`‎lib/rules/attributes-order.js‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@ function getAttributeType (name, isDirective) {`
`23`	`23`	`return 'EVENTS'`
`24`	`24`	`} else if (name === 'html' \|\| name === 'text') {`
`25`	`25`	`return 'CONTENT'`
	`26`	`+ } else {`
	`27`	`+ return 'OTHER_ATTR'`
`26`	`28`	`}`
`27`	`29`	`} else {`
`28`	`30`	`if (name === 'is') {`

`‎tests/lib/rules/attributes-order.js‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,10 @@ tester.run('attributes-order', rule, {`
`82`	`82`	`filename: 'test.vue',`
`83`	`83`	`code: '<template><div v-model="toggle"></div></template>'`
`84`	`84`	`},`
	`85`	`+ {`
	`86`	`+ filename: 'test.vue',`
	`87`	`+ code: '<template><div v-custom-directive></div></template>'`
	`88`	`+ },`
`85`	`89`	`{`
`86`	`90`	`filename: 'test.vue',`
`87`	`91`	`code:`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 8c0399f

File tree

3 files changed

3 files changed

`‎docs/rules/attributes-order.md‎`

`‎lib/rules/attributes-order.js‎`

`‎tests/lib/rules/attributes-order.js‎`

0 commit comments