Commit fcea63a

authored

Update event type validation method to IsValid and add code generation tool for validation methods. (#9403)

1 parent 42b050a commit fcea63aCopy full SHA for fcea63a

File tree

+199

-27

lines changed

+199

-27

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ func (a *Action) Validate() error {`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`func validateEvent(event graveler.EventType, on *ActionOn) error {`
`104`		`- if !event.Valid() {`
	`104`	`+ if !event.IsValid() {`
`105`	`105`	`return fmt.Errorf("event '%s' is not supported: %w", event, ErrInvalidAction)`
`106`	`106`	`}`
`107`	`107`	`if on != nil {`

Lines changed: 4 additions & 26 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`	`1`	`package graveler`
`2`	`2`
	`3`	`+//go:generate go run github.com/treeverse/lakefs/tools/isvalidgen --source ./hooks_handler.go --type EventType`
	`4`	`+`
`3`	`5`	`import (`
`4`	`6`	`"context"`
`5`	`7`	`"time"`
`@@ -28,34 +30,10 @@ const (`
`28`	`30`	`EventTypePostRevert EventType = "post-revert"`
`29`	`31`	`EventTypePreCherryPick EventType = "pre-cherry-pick"`
`30`	`32`	`EventTypePostCherryPick EventType = "post-cherry-pick"`
`31`		`-`
`32`		`- UnixYear3000 = 32500915200`
`33`	`33`	`)`
`34`	`34`
`35`		`-func (e EventType) Valid() bool {`
`36`		`- switch e {`
`37`		`- case EventTypePrepareCommit,`
`38`		`- EventTypePreCommit,`
`39`		`- EventTypePostCommit,`
`40`		`- EventTypePreMerge,`
`41`		`- EventTypePostMerge,`
`42`		`- EventTypePreCreateBranch,`
`43`		`- EventTypePostCreateBranch,`
`44`		`- EventTypePreDeleteBranch,`
`45`		`- EventTypePostDeleteBranch,`
`46`		`- EventTypePreCreateTag,`
`47`		`- EventTypePostCreateTag,`
`48`		`- EventTypePreDeleteTag,`
`49`		`- EventTypePostDeleteTag,`
`50`		`- EventTypePreRevert,`
`51`		`- EventTypePostRevert,`
`52`		`- EventTypePreCherryPick,`
`53`		`- EventTypePostCherryPick:`
`54`		`- // Supported events`
`55`		`- return true`
`56`		`- }`
`57`		`- return false`
`58`		`-}`
	`35`	`+// UnixYear3000 used by NewRunID for generating run IDs in reverse order`
	`36`	`+const UnixYear3000 = 32500915200`
`59`	`37`
`60`	`38`	`// HookRecord is an aggregation of all necessary fields for all event types`
`61`	`39`	`type HookRecord struct {`

Lines changed: 28 additions & 0 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Lines changed: 166 additions & 0 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Comments

(0)