-
-
Notifications
You must be signed in to change notification settings - Fork 76
Require argument parameters #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade `commander` to v8 to bring in support for `.choices()`.
@vladimyr
vladimyr
changed the title
(削除) Revert "Fix missing render path error (#354)" (削除ここまで)
(追記) Require argument parameters (追記ここまで)
Jun 30, 2021
marchersimon
marchersimon
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
owenvoke
owenvoke
reviewed
Jul 1, 2021
Co-authored-by: Owen Voke <development@voke.dev>
blueskyson
blueskyson
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Require argument parameters and limit
-o, --osargument choices.(Bumps
commanderto v8.)/cc @marchersimon
Checklist
Please review this checklist before submitting a pull request.
npm run test:all)