Commit af73f5d

authored

Ensure useFetch suspends when triggering a service call more than once

useFetch experimental support for React Suspense works great when the call made is only used once. In the event of an application successfully suspending after a service call, and then triggering that same call again, the suspense mechanism does not suspend as expected. This is because the suspenseStatus ref used to keep track of the suspense status is never reset! This change makes it so that when the suspense promise is created, the suspenseStatus ref is reset so that the promise can be successfully thrown for React to catch.

1 parent 6225d32 commit af73f5dCopy full SHA for af73f5d

File tree

1 file changed

-0

lines changed

src
- useFetch.ts

1 file changed

-0

lines changed

`‎src/useFetch.ts‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,7 @@ function useFetch<TData = any>(...args: UseFetchArgs): UseFetch<TData> {`
`182`	`182`
`183`	`183`	`if (suspense) {`
`184`	`184`	`return async (...args) => {`
	`185`	`+ suspenseStatus.current = 'pending'`
`185`	`186`	`suspender.current = doFetch(...args).then(`
`186`	`187`	`(newData) => {`
`187`	`188`	`suspenseStatus.current = 'success'`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit af73f5d

File tree

1 file changed

1 file changed

`‎src/useFetch.ts‎`

0 commit comments