Commit f6a1677

authored

chore: Adjust tests to workaround 18.3.0 bug (#1315)

1 parent d143f46 commit f6a1677Copy full SHA for f6a1677

File tree

+11

-5

lines changed

+11

-5

lines changed

Lines changed: 2 additions & 2 deletions

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,6 @@ class StopWatch extends React.Component {`
`40`	`40`	`const sleep = t => new Promise(resolve => setTimeout(resolve, t))`
`41`	`41`
`42`	`42`	`test('unmounts a component', async () => {`
`43`		`- jest.spyOn(console, 'error').mockImplementation(() => {})`
`44`	`43`	`const {unmount, container} = render(<StopWatch />)`
`45`	`44`	`fireEvent.click(screen.getByText('Start'))`
`46`	`45`	`unmount()`
`@@ -52,6 +51,4 @@ test('unmounts a component', async () => {`
`52`	`51`	`// if it's not, then we'll call setState on an unmounted component`
`53`	`52`	`// and get an error.`
`54`	`53`	`await sleep(5)`
`55`		`- // eslint-disable-next-line no-console`
`56`		`- expect(console.error).not.toHaveBeenCalled()`
`57`	`54`	`})`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,15 @@ module.exports = function shouldIgnoreConsoleError(format) {`
`36`	`36`	`// Ignore it too.`
`37`	`37`	`return true`
`38`	`38`	`}`
	`39`	`+ if (`
	`40`	`+ format.startsWith(`
	`41`	+ 'Warning: `ReactDOMTestUtils.act` is deprecated in favor of `React.act`.',
	`42`	`+ )`
	`43`	`+ ) {`
	`44`	`+ // This is a React bug in 18.3.0.`
	`45`	+ // Versions with `ReactDOMTestUtils.ac` being deprecated, should have `React.act`
	`46`	`+ return true`
	`47`	`+ }`
`39`	`48`	`}`
`40`	`49`	`}`
`41`	`50`	`// Looks legit`

Comments

(0)