Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 8f80520

Browse files
committed
fix: Update 'onCaughtError' type inference in 'RenderOptions' to work with React v19
1 parent 9fc6a75 commit 8f80520

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

‎types/index.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ export interface RenderOptions<
127127
* @see {@link https://react.dev/reference/react-dom/client/createRoot#parameters createRoot#options}
128128
*/
129129
onCaughtError?: ReactDOMClient.RootOptions extends {
130-
onCaughtError: infer OnCaughtError
130+
onCaughtError?: infer OnCaughtError
131131
}
132132
? OnCaughtError
133133
: never

‎types/test.tsx‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,11 +264,9 @@ export function testContainer() {
264264
}
265265

266266
export function testErrorHandlers() {
267-
// React 19 types are not used in tests. Verify manually if this works with `"@types/react": "npm:types-react@rc"`
267+
// React 19 types are currently used in tests.
268268
render(null, {
269269
// Should work with React 19 types
270-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
271-
// @ts-expect-error
272270
onCaughtError: () => {},
273271
})
274272
render(null, {

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /