Commit 801edaa

leschdomMatanBobi

and

authored

docs(CONTRIBUTING): update links (#932)

* docs(CONTRIBUTING): update links ... the old egghead.io link redirects to https://app.egghead.io/playlists/how-to-contribute-to-an-open-source-project-on-github which displays "We've got a new version of egghead in BETA. Click here to try it!" remove obsolete all-contributors link (was removed in 29aad25) * docs: use consistent spelling for TypeScript ... inspired by https://effectivetypescript.com/2021/02/03/pet-peeves/ Co-authored-by: Matan Borenkraout <Matanbobi@gmail.com>

1 parent 6e6bf85 commit 801edaaCopy full SHA for 801edaa

File tree

-6

lines changed

-6

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ merge of your pull request!`
`37`	`37`	`- [ ] Documentation added to the`
`38`	`38`	`[docs site](https://github.com/testing-library/testing-library-docs)`
`39`	`39`	`- [ ] Tests`
`40`		`-- [ ] Typescript definitions updated`
	`40`	`+- [ ] TypeScript definitions updated`
`41`	`41`	`- [ ] Ready to be merged`
`42`	`42`	`<!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->`
`43`	`43`

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -35,11 +35,11 @@ sure to include those changes (if they exist) in your commit.`
`35`	`35`	`### Update Typings`
`36`	`36`
`37`	`37`	`If your PR introduced some changes in the API, you are more than welcome to`
`38`		`-modify the Typescript type definition to reflect those changes. Just modify the`
`39`		-`/types/index.d.ts` file accordingly. If you have never seen Typescript
	`38`	`+modify the TypeScript type definition to reflect those changes. Just modify the`
	`39`	+`/types/index.d.ts` file accordingly. If you have never seen TypeScript
`40`	`40`	`definitions before, you can read more about it in its`
`41`	`41`	`[documentation pages](https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html).`
`42`		`-Though this library itself is not written in Typescript we use`
	`42`	`+Though this library itself is not written in TypeScript we use`
`43`	`43`	`[dtslint](https://github.com/microsoft/dtslint) to lint our typings.`
`44`	`44`
`45`	`45`	`## Help needed`
`@@ -50,6 +50,5 @@ Also, please watch the repo and respond to questions/bug reports/feature`
`50`	`50`	`requests! Thanks!`
`51`	`51`
`52`	`52`	`[egghead]:`
`53`		`- https://app.egghead.io/series/how-to-contribute-to-an-open-source-project-on-github`
`54`		`-[all-contributors]: https://github.com/all-contributors/all-contributors`
	`53`	`+ https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github`
`55`	`54`	`[issues]: https://github.com/testing-library/react-testing-library/issues`

Comments

(0)