-
-
Notifications
You must be signed in to change notification settings - Fork 349
feat: Support for Security Hub #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for Security Hub #242
Conversation
This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days
This is ready for a review
CI failed check needs to be remediated
CI failed check needs to be remediated
Fixed the majority of them - some of the linting issue i believe are not a result of my changes. Especially
/notify_slack.py:506:1: C901 'get_slack_message_payload' is too complex (11)
This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days
Not stale: Looking for feedback on what to do regarding the changes that were made outside of this PR which are breaking the CI
This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days
Not stale: Looking for feedback on what to do regarding the changes that were made outside of this PR which are breaking the CI
Not stale: Looking for feedback on what to do regarding the changes that were made outside of this PR which are breaking the CI
Fix it?
@bryantbiggs I misunderstood the error message given by flake8. Refactoring parsing of the notification into a dedicated function should resolve the complexity error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
3aef5ba
into
terraform-aws-modules:master
## [6.6.0](v6.5.2...v6.6.0) (2025年03月12日) ### Features * Support for Security Hub ([#242](#242)) ([3aef5ba](3aef5ba))
This PR is included in version 6.6.0 🎉
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
Adding support for parsing of security hub messages into a readable slack message.
image
Examples:
image
image
Motivation and Context
#207
#221
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request