Commit 6000808

authored

Fix to allow other strings for boolean attributes

Closes GH-45. Closes GH-46. Reviewed-by: Titus Wormer <tituswormer@gmail.com>

1 parent fb74df8 commit 6000808Copy full SHA for 6000808

File tree

+45

-2

lines changed

+45

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -173,8 +173,8 @@ function serializeAttribute(state, key, value) {`
`173`	`173`	`if (info.overloadedBoolean && (value === info.attribute \|\| value === '')) {`
`174`	`174`	`value = true`
`175`	`175`	`} else if (`
`176`		`- info.boolean\|\|`
`177`		`- (info.overloadedBoolean&&typeofvalue!=='string')`
	`176`	`+ (typeofvalue!=='string'\|\|value===''\|\|value===info.attribute)&&`
	`177`	`+ (info.boolean\|\|info.overloadedBoolean)`
`178`	`178`	`) {`
`179`	`179`	`value = Boolean(value)`
`180`	`180`	`}`

Lines changed: 43 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -161,6 +161,49 @@ test('`element` attributes', async (t) => {
`161`	`161`	`)`
`162`	`162`	`}`
`163`	`163`	`)`
	`164`	`+`
	`165`	`+ await t.test(`
	`166`	`+ 'should serialize known booleans set to arbitrary strings with value',`
	`167`	`+ async function () {`
	`168`	`+ assert.deepEqual(`
	`169`	`+ toHtml(`
	`170`	`+ h('div', {`
	`171`	`+ selected: 'some string value for a well known boolean attribute'`
	`172`	`+ })`
	`173`	`+ ),`
	`174`	`+ '<div selected="some string value for a well known boolean attribute"></div>'`
	`175`	`+ )`
	`176`	`+ }`
	`177`	`+ )`
	`178`	`+`
	`179`	`+ await t.test(`
	`180`	`+ 'should serialize known booleans set to an empty string without value',`
	`181`	`+ async function () {`
	`182`	`+ assert.deepEqual(`
	`183`	`+ toHtml(`
	`184`	`+ h('div', {`
	`185`	`+ selected: ''`
	`186`	`+ })`
	`187`	`+ ),`
	`188`	`+ '<div selected></div>'`
	`189`	`+ )`
	`190`	`+ }`
	`191`	`+ )`
	`192`	`+`
	`193`	`+ await t.test(`
	`194`	`+ 'should serialize known overloaded booleans set to arbitrary strings with value',`
	`195`	`+ async function () {`
	`196`	`+ assert.deepEqual(`
	`197`	`+ toHtml(`
	`198`	`+ h('div', {`
	`199`	`+ download:`
	`200`	`+ 'some string value for a well known overloaded boolean attribute'`
	`201`	`+ })`
	`202`	`+ ),`
	`203`	`+ '<div download="some string value for a well known overloaded boolean attribute"></div>'`
	`204`	`+ )`
	`205`	`+ }`
	`206`	`+ )`
`164`	`207`	`})`
`165`	`208`
`166`	`209`	`await t.test('should support known overloaded booleans', async function (t) {`

Comments

(0)