Commit a1ec259

authored

Fix invalid array termination for null and undefined (#38)

* Add test case to check invalid terminator * Fix invalid array termination

1 parent 04dc4ad commit a1ec259Copy full SHA for a1ec259

File tree

-4

lines changed

IntegrationTests
- TestSuites/Sources/PrimaryTests
  - main.swift
- bin
  - primary-tests.js
Sources/JavaScriptKit
- JSArrayRef.swift

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ test("Array Iterator") {`
`88`	`88`	`let prop_4 = getJSValue(this: globalObject1Ref, name: "prop_4")`
`89`	`89`	`let array = try expectArray(prop_4)`
`90`	`90`	`let expectedProp_4: [JSValue] = [`
`91`		`- .number(3), .number(4), .string("str_elm_1"), .number(5),`
	`91`	`+ .number(3), .number(4), .string("str_elm_1"), .null,.undefined,.number(5),`
`92`	`92`	`]`
`93`	`93`	`try expectEqual(Array(array), expectedProp_4)`
`94`	`94`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ global.globalObject1 = {`
`5`	`5`	`"prop_2": 2,`
`6`	`6`	`"prop_3": true,`
`7`	`7`	`"prop_4": [`
`8`		`- 3, 4, "str_elm_1", 5,`
	`8`	`+ 3, 4, "str_elm_1", null,undefined,5,`
`9`	`9`	`],`
`10`	`10`	`"prop_5": {`
`11`	`11`	`"func1": function () { return },`
`@@ -41,4 +41,4 @@ const { startWasiTask } = require("../lib")`
`41`	`41`
`42`	`42`	`startWasiTask("./dist/PrimaryTests.wasm").catch(err => {`
`43`	`43`	`console.log(err)`
`44`		`-});`
	`44`	`+});`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ extension JSArrayRef: RandomAccessCollection {`
`34`	`34`	`return nil`
`35`	`35`	`}`
`36`	`36`	`let value = ref[index]`
`37`		`- return value.isNull ?nil: value`
	`37`	`+ return value`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`

Comments

(0)