-
Notifications
You must be signed in to change notification settings - Fork 6k
[JavaPlayFramework] Various fixes for different CLI options #6121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@wing328 : You will probably need to add chmod to the new "all" .sh. Since I'm in windows, I can't commit this kind of thing. And please all of this to the CI.
I'll take care of it. Thanks for the heads-up.
wing328
wing328
reviewed
Jul 20, 2017
public class {{classname}}Controller extends Controller {
private final {{classname}}ControllerImp imp;
{{^controllerOnly}}private final {{classname}}ControllerImp imp;{{/controllerOnly}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JFCote next time you may want to use the following instead to avoid the leading spaces:
{{^controllerOnly}}
private final {{classname}}ControllerImp imp;
{{/controllerOnly}}
@wing328
wing328
changed the title
(削除) [JavaPlayFramework] Fix for issue #6094 (削除ここまで)
(追記) [JavaPlayFramework] Various fixes for different CLI options (追記ここまで)
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for breaking (non-backward compatible) changes.Description of the PR
Fix issue #6094
I have created a sample .sh file for each case, finding numerous bugs along the way since on my project I only use default value. Thanks a lot :)
@wing328 : You will probably need to add chmod to the new "all" .sh. Since I'm in windows, I can't commit this kind of thing. And please all of this to the CI.