Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add @Valid annotion for bean-validation #5517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@fisherliu
Copy link
Contributor

@fisherliu fisherliu commented Apr 30, 2017
edited
Loading

#5393:
https://github.com/cakemail/swagger-codegen/blob/07f066a20350302429c133f2febfcb58632aa56a/modules/swagger-codegen/src/main/resources/JavaSpring/beanValidation.mustache

the change below was added into JavaSpring language but it was not added into Java language.

so I have created the PR to support @Valid for java language to implement #5498
[JAVA] enhance beanvalidation with adding @Valid

Copy link
Contributor

wing328 commented May 1, 2017

@fisherliu thanks for the PR. Please also run ./bin/java-petstore-all.sh to update the Java Petstore samples so that the CIs can verify the test.

cc @cbornet @jfiala

Copy link
Contributor

wing328 commented May 1, 2017

FYI. The CI tests with updated Petstore passed: https://travis-ci.org/swagger-api/swagger-codegen/builds/227529313

Let me know if you need help updating the Petstore samples for Java.

Copy link
Contributor Author

@wing328 ,thank you for your help. when will the change can be merged into master branch?it will to to version 2.2.3 or 2.3.0?

j-mccloskey reacted with thumbs up emoji

Copy link
Contributor Author

hi @wing328, what's the next step for the PR? I noticed it has passed the checks.

@wing328 wing328 added this to the v2.2.3 milestone May 4, 2017
@wing328 wing328 merged commit d08d55d into swagger-api:master May 4, 2017
Copy link
Contributor

wing328 commented May 4, 2017

@fisherliu I've just merged it. Please update the Petstore samples next time so that the CIs can test the change.

Copy link
Contributor

wing328 commented May 4, 2017

when will the change can be merged into master branch?it will to to version 2.2.3 or 2.3.0?

Enhancements to master (2.2.3) will be sync'd to 2.3.0 as well.

Copy link

When will this be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

v2.2.3

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /