Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update User-Agent for Ruby, Python, PHP, Java, Android #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 5 commits into swagger-api:master from wing328:user_agent_update
Mar 15, 2016

Conversation

@wing328
Copy link
Contributor

@wing328 wing328 commented Mar 14, 2016

Make the User-Agent configurable via --http-user-agent CLI option.

Default to Swagger-Codegen/{version}/{language}

jqr, janxious, and MartinHatas reacted with heart emoji
wing328 added a commit that referenced this pull request Mar 15, 2016
Update User-Agent for Ruby, Python, PHP, Java, Android
@wing328 wing328 merged commit d02d3df into swagger-api:master Mar 15, 2016
Copy link
Contributor

jqr commented Mar 15, 2016

I'm curious why this was made an option to generate instead of something in the config.json. Is there a general move towards options for new things?

Copy link
Contributor Author

wing328 commented Mar 15, 2016

You can also supply the CLI option in the config, e.g.

{
 "sortParamsByRequiredFlag": true,
 "optionalAssemblyInfo": true,
 "httpUserAgent": "XXXXXX"
}

I did a test and worked for me. Can you give that a try?

sashank reacted with thumbs up emoji

@wing328 wing328 deleted the user_agent_update branch March 15, 2016 15:55
Copy link
Contributor

jqr commented Mar 15, 2016

Ah, that makes sense. Thanks!

Copy link

inska commented Apr 27, 2016

Hi @wing328,

When can I do like this on the Swift Client?

Thanks,

Copy link
Contributor Author

wing328 commented Apr 27, 2016

@inska I don't think anyone from the community has started working on it. I'll create a separate task for tracking to implement customisable user-agent in other langauges.

inska reacted with heart emoji

@wing328 wing328 mentioned this pull request Apr 27, 2016
17 tasks
Copy link
Contributor Author

wing328 commented Apr 27, 2016

Now track via #2715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

v2.1.6

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /