This repository was archived by the owner on Nov 9, 2022. It is now read-only.

Commit d791465

committed

FIX: unbreak ipympl

We must not try to make a toolbar for the classes in backend_webaggcore because ipympl inherits from these classes and requires its own toolbar to be used. This also fixes the webagg embedding example without breaking ipympl. closes matplotlib#23699

1 parent 942aa77 commit d791465Copy full SHA for d791465

File tree

3 files changed

+10

-2

lines changed

examples/user_interfaces
- embedding_webagg_sgskip.py
lib/matplotlib
- backends
  - backend_webagg_core.py
- tests
  - test_backend_webagg.py

3 files changed

+10

-2

lines changed

`‎examples/user_interfaces/embedding_webagg_sgskip.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`
`31`	`31`
`32`	`32`	`import matplotlib as mpl`
`33`		`-from matplotlib.backends.backend_webagg_core import (`
	`33`	`+from matplotlib.backends.backend_webagg import (`
`34`	`34`	`FigureManagerWebAgg, new_figure_manager_given_figure)`
`35`	`35`	`from matplotlib.figure import Figure`
`36`	`36`

`‎lib/matplotlib/backends/backend_webagg_core.py‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,9 @@ def set_history_buttons(self):`
`427`	`427`
`428`	`428`
`429`	`429`	`class FigureManagerWebAgg(backend_bases.FigureManagerBase):`
`430`		`- _toolbar2_class = ToolbarCls = NavigationToolbar2WebAgg`
	`430`	`+ # This must be None to not break ipympl`
	`431`	`+ _toolbar2_class = None`
	`432`	`+ ToolbarCls = NavigationToolbar2WebAgg`
`431`	`433`
`432`	`434`	`def __init__(self, canvas, num):`
`433`	`435`	`self.web_sockets = set()`

`‎lib/matplotlib/tests/test_backend_webagg.py‎`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`import os`
`3`	`3`	`import sys`
`4`	`4`	`import pytest`
	`5`	`+import matplotlib.backends.backend_webagg_core`
`5`	`6`
`6`	`7`
`7`	`8`	`@pytest.mark.parametrize("backend", ["webagg", "nbagg"])`
`@@ -25,3 +26,8 @@ def test_webagg_fallback(backend):`
`25`	`26`	`ret = subprocess.call([sys.executable, "-c", test_code], env=env)`
`26`	`27`
`27`	`28`	`assert ret == 0`
	`29`	`+`
	`30`	`+`
	`31`	`+def test_webagg_core_no_toolbar():`
	`32`	`+ fm = matplotlib.backends.backend_webagg_core.FigureManagerWebAgg`
	`33`	`+ assert fm._toolbar2_class is None`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit d791465

File tree

3 files changed

3 files changed

`‎examples/user_interfaces/embedding_webagg_sgskip.py‎`

`‎lib/matplotlib/backends/backend_webagg_core.py‎`

`‎lib/matplotlib/tests/test_backend_webagg.py‎`

0 commit comments