This repository was archived by the owner on Nov 9, 2022. It is now read-only.

Commit b3ef9b0

committed

Code review

1 parent ed883da commit b3ef9b0Copy full SHA for b3ef9b0

File tree

-10

lines changed

-10

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,9 +8,9 @@ How to define the view angle`
`8`	`8`	`============================`
`9`	`9`
`10`	`10`	`The position of the viewport "camera" in a 3D plot is defined by three angles:`
`11`		`-elevation, azimuth, and roll. From the resulting position, it always points`
`12`		`-towards the center of the plot box volume. The angle direction convention is`
`13`		`-shared with`
	`11`	`+elevation, azimuth, and roll. From the resulting position, it always`
	`12`	`+points towards the center of the plot box volume. The angle direction is a`
	`13`	`+common convention, and is shared with`
`14`	`14`	`PyVista <https://docs.pyvista.org/api/core/camera.html>`_ and
`15`	`15`	`MATLAB <https://www.mathworks.com/help/matlab/ref/view.html>`_
`16`	`16`	`(though MATLAB lacks a roll angle). Note that a positive roll angle rotates the`

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ def annotate_axes(ax, text, fontsize=18):`
`16`	`16`	`ax.text(x=0.5, y=0.5, z=0.5, s=text,`
`17`	`17`	`va="center", ha="center", fontsize=fontsize, color="black")`
`18`	`18`
`19`		`-# (view, (elev, azim, roll))`
	`19`	`+# (plane, (elev, azim, roll))`
`20`	`20`	`views = [('XY', (90, -90, 0)),`
`21`	`21`	`('XZ', (0, -90, 0)),`
`22`	`22`	`('YZ', (0, 0, 0)),`
`@@ -29,18 +29,15 @@ def annotate_axes(ax, text, fontsize=18):`
`29`	`29`	`['.', '.', '-XY', '.']]`
`30`	`30`	`fig, axd = plt.subplot_mosaic(layout, subplot_kw={'projection': '3d'},`
`31`	`31`	`figsize=(12, 8.5))`
`32`		`-for i in range(len(axd) - 1):`
`33`		`- plane = views[i][0]`
	`32`	`+for plane, angles in views:`
`34`	`33`	`axd[plane].set_xlabel('x')`
`35`	`34`	`axd[plane].set_ylabel('y')`
`36`	`35`	`axd[plane].set_zlabel('z')`
`37`	`36`	`axd[plane].set_proj_type('ortho')`
`38`		`- axd[plane].view_init(elev=views[i][1][0],`
`39`		`- azim=views[i][1][1],`
`40`		`- roll=views[i][1][2])`
	`37`	`+ axd[plane].view_init(elev=angles[0], azim=angles[1], roll=angles[2])`
`41`	`38`	`axd[plane].set_box_aspect(None, zoom=1.25)`
`42`	`39`
`43`		`- label = f'{plane}\n{views[i][1]}'`
	`40`	`+ label = f'{plane}\n{angles}'`
`44`	`41`	`annotate_axes(axd[plane], label, fontsize=14)`
`45`	`42`
`46`	`43`	`for plane in ('XY', '-XY'):`

Comments

(0)