This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Commit c1086ea

committed

refactor: use bufPool

Signed-off-by: Nao YONASHIRO <owan.orisano@gmail.com>

1 parent f2fd929 commit c1086eaCopy full SHA for c1086ea

File tree

-12

lines changed

-12

lines changed

Lines changed: 3 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ package packfile`
`3`	`3`	`import (`
`4`	`4`	`"bytes"`
`5`	`5`	`"errors"`
`6`		`- "sync"`
`7`	`6`
`8`	`7`	`"gopkg.in/src-d/go-git.v4/plumbing"`
`9`	`8`	`)`
`@@ -15,12 +14,6 @@ import (`
`15`	`14`
`16`	`15`	`const deltaSizeMin = 4`
`17`	`16`
`18`		`-var bytesBufferPool = sync.Pool{`
`19`		`- New: func() interface{} {`
`20`		`- return &bytes.Buffer{}`
`21`		`- },`
`22`		`-}`
`23`		`-`
`24`	`17`	`// ApplyDelta writes to target the result of applying the modification deltas in delta to base.`
`25`	`18`	`func ApplyDelta(target, base plumbing.EncodedObject, delta []byte) error {`
`26`	`19`	`r, err := base.Reader()`
`@@ -33,11 +26,9 @@ func ApplyDelta(target, base plumbing.EncodedObject, delta []byte) error {`
`33`	`26`	`return err`
`34`	`27`	`}`
`35`	`28`
`36`		`- buf := bytesBufferPool.Get().(*bytes.Buffer)`
`37`		`- defer func() {`
`38`		`- buf.Reset()`
`39`		`- bytesBufferPool.Put(buf)`
`40`		`- } ()`
	`29`	`+ buf := bufPool.Get().(*bytes.Buffer)`
	`30`	`+ defer bufPool.Put(buf)`
	`31`	`+ buf.Reset()`
`41`	`32`	`_, err = buf.ReadFrom(r)`
`42`	`33`	`if err != nil {`
`43`	`34`	`return err`

Comments

(0)