You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<p>Converters from sqlobject/converters.py aren't visible to the user. They
84
+
<p>Converters from <ahref="sqlobject/converters.py.html" class="reference external">sqlobject/converters.py</a> aren't visible to the user. They
85
85
are used behind the scene to convert object to SQL strings. The most
86
86
elaborated converter there is StringConverters. Yes, it converts strings
87
87
to strings. It converts python strings to SQL strings using
@@ -99,7 +99,7 @@ <h1>Style Guide</h1>
99
99
<ul>
100
100
<li><pclass="first"><strong>No tabs</strong>. Not anywhere. Always indent with 4 spaces.</p>
101
101
</li>
102
-
<li><pclass="first">I don't stress too much on line length. But try to break lines up
102
+
<li><pclass="first">We don't stress too much on line length. But try to break lines up
103
103
by grouping with parenthesis instead of with backslashes (if you
104
104
can). Do asserts like:</p>
105
105
<preclass="literal-block">
@@ -120,7 +120,7 @@ <h1>Style Guide</h1>
120
120
sqlobject import *</tt> so names should be fairly distinct, or they
121
121
shouldn't be exported in <ttclass="docutils literal">sqlobject.__init__</tt>.</p>
122
122
</li>
123
-
<li><pclass="first">I'm very picky about whitespace. There's one and only one right way
123
+
<li><pclass="first">We're very picky about whitespace. There's one and only one right way
124
124
to do it. Good examples:</p>
125
125
<preclass="literal-block">
126
126
short = 3
@@ -144,9 +144,9 @@ <h1>Style Guide</h1>
144
144
func( a, b )
145
145
[ 1, 2, 3 ]
146
146
</pre>
147
-
<p>To me, the poor use of whitespace seems lazy. I'll think less of
148
-
your code (justified or not) for this very trivial reason. I will
149
-
fix all your code for you if you don't do it yourself, because I
147
+
<p>To us, the poor use of whitespace seems lazy. We'll think less of
148
+
your code (justified or not) for this very trivial reason. We will
149
+
fix all your code for you if you don't do it yourself, because we
150
150
can't bear to look at sloppy whitespace.</p>
151
151
</li>
152
152
<li><pclass="first">Use <ttclass="docutils literal">@@</tt> to mark something that is suboptimal, or where you have a
@@ -221,8 +221,8 @@ <h1>Testing</h1>
221
221
<p>If you <ttclass="docutils literal">import *</tt> you'll also get py.test's version of <ahref="http://pytest.org/latest/assert.html#assertions-about-expected-exceptions" class="reference external">raises</a>, an
222
222
<ttclass="docutils literal">inserts</tt> function that can create instances for you, and a couple
223
223
miscellaneous functions.</p>
224
-
<p>If you submit a patch or implement a feature without a test, I'll be
225
-
forced to write the test. That's no fun for me, to just be writing
224
+
<p>If you submit a patch or implement a feature without a test, we'll be
225
+
forced to write the test. That's no fun for us, to just be writing
226
226
tests. So please, write tests; everything at least needs to be
227
227
exercised, even if the tests are absolutely complete.</p>
228
228
<p>We now use Travis CI to run tests. See the status:</p>
0 commit comments