Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Help wanted? #2

Closed
rjokelai started this conversation in General
Aug 15, 2023 · 3 comments · 4 replies
Discussion options

Hi @4kimov, I would be interested in helping the JS version come alive. Anything I could do?

You must be logged in to vote

Replies: 3 comments 4 replies

Comment options

@rjokelai Thanks for pinging. Sure, there's plenty you can do -- the rough code is there, what's missing is proper linting, formatting, making all the scripts work properly, optimizations, packaging it properly, etc. Gave you access if you'd like to give it a go.

You must be logged in to vote
2 replies
Comment options

Thank you. Do you have any guidelines that you want to enforce across the implementations or am I free to do as I please here?

Comment options

The major things are to have identical tests across implementations (which is already done for the JS version). I'd recommend leaving the README as is for now (with the exception of removing the "work-in-progress" notice), and focusing on just making all the npm run scripts work + making Github Actions pass.

Comment options

Hello, I was just trying out the package, and it does not support BigInt. What would be a good way to support this or there any plan to? It basically requires everything that returns Number be casted to BigInt for calculation parts. What do you think?

You must be logged in to vote
1 reply
Comment options

Hello, thanks for the question. Let's move the discussion here: #4. No immediate plans to address this yet, but if you'd like to create a PR for it, I could review.

Comment options

@4kimov what is the current state? Do you see anything (with priority) that needs to be done?

You must be logged in to vote
1 reply
Comment options

There's nothing that's urgent on the JS package. It's missing bigint support, but other than that fully usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet

AltStyle によって変換されたページ (->オリジナル) /