Commit c8196b5

committed

Polishing.

Reformat code, tweak visibility. See #2147

1 parent 6ac7e6a commit c8196b5Copy full SHA for c8196b5

File tree

2 files changed

+16

-16

lines changed

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect
- JdbcSqlServerDialectTest.java
spring-data-relational/src/test/java/org/springframework/data/relational/core/dialect
- SqlServerDialectUnitTests.java

2 files changed

+16

-16

lines changed

`‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcSqlServerDialectTest.java‎`

Lines changed: 10 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,13 @@`
`15`	`15`	`*/`
`16`	`16`	`package org.springframework.data.jdbc.core.dialect;`
`17`	`17`
	`18`	`+import static org.assertj.core.api.Assertions.*;`
	`19`	`+`
`18`	`20`	`import java.time.Instant;`
`19`	`21`	`import java.util.List;`
`20`	`22`
`21`		`-import org.assertj.core.api.Assertions;`
`22`	`23`	`import org.junit.jupiter.api.Test;`
	`24`	`+`
`23`	`25`	`import org.springframework.data.jdbc.core.convert.JdbcCustomConversions;`
`24`	`26`
`25`	`27`	`/**`
`@@ -29,14 +31,12 @@`
`29`	`31`	`*/`
`30`	`32`	`class JdbcSqlServerDialectTest {`
`31`	`33`
`32`		`-@Test // GH-1873`
`33`		`-void testCustomConversions() {`
	`34`	`+@Test // GH-1873`
	`35`	`+void testCustomConversions() {`
`34`	`36`
`35`		`- JdbcCustomConversions jdbcCustomConversions = new JdbcCustomConversions(`
`36`		`- (List<?>) JdbcSqlServerDialect.INSTANCE.getConverters());`
	`37`	`+ JdbcCustomConversions conversions = JdbcCustomConversions.of(JdbcSqlServerDialect.INSTANCE, List.of());`
`37`	`38`
`38`		`- Assertions`
`39`		`- .assertThat(jdbcCustomConversions.hasCustomReadTarget(microsoft.sql.DateTimeOffset.class, Instant.class))`
`40`		`- .isTrue();`
`41`		`- }`
`42`		`-}`
	`39`	`+ assertThat(conversions.hasCustomReadTarget(microsoft.sql.DateTimeOffset.class, Instant.class))`
	`40`	`+ .isTrue();`
	`41`	`+ }`
	`42`	`+}`

`‎spring-data-relational/src/test/java/org/springframework/data/relational/core/dialect/SqlServerDialectUnitTests.java‎`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,10 +30,10 @@`
`30`	`30`	`* @author Mark Paluch`
`31`	`31`	`* @author Myeonghyeon Lee`
`32`	`32`	`*/`
`33`		`-publicclass SqlServerDialectUnitTests {`
	`33`	`+class SqlServerDialectUnitTests {`
`34`	`34`
`35`	`35`	`@Test // DATAJDBC-278`
`36`		`- publicvoid shouldNotSupportArrays() {`
	`36`	`+ void shouldNotSupportArrays() {`
`37`	`37`
`38`	`38`	`ArrayColumns arrayColumns = SqlServerDialect.INSTANCE.getArraySupport();`
`39`	`39`
`@@ -42,7 +42,7 @@ public void shouldNotSupportArrays() {`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`@Test // DATAJDBC-278`
`45`		`- publicvoid shouldRenderLimit() {`
	`45`	`+ void shouldRenderLimit() {`
`46`	`46`
`47`	`47`	`LimitClause limit = SqlServerDialect.INSTANCE.limit();`
`48`	`48`
`@@ -51,23 +51,23 @@ public void shouldRenderLimit() {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`@Test // DATAJDBC-278`
`54`		`- publicvoid shouldRenderOffset() {`
	`54`	`+ void shouldRenderOffset() {`
`55`	`55`
`56`	`56`	`LimitClause limit = SqlServerDialect.INSTANCE.limit();`
`57`	`57`
`58`	`58`	`assertThat(limit.getOffset(10)).isEqualTo("OFFSET 10 ROWS");`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`@Test // DATAJDBC-278`
`62`		`- publicvoid shouldRenderLimitOffset() {`
	`62`	`+ void shouldRenderLimitOffset() {`
`63`	`63`
`64`	`64`	`LimitClause limit = SqlServerDialect.INSTANCE.limit();`
`65`	`65`
`66`	`66`	`assertThat(limit.getLimitOffset(20, 10)).isEqualTo("OFFSET 10 ROWS FETCH NEXT 20 ROWS ONLY");`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`@Test // DATAJDBC-498`
`70`		`- publicvoid shouldRenderLock() {`
	`70`	`+ void shouldRenderLock() {`
`71`	`71`
`72`	`72`	`LockClause lock = SqlServerDialect.INSTANCE.lock();`
`73`	`73`	`From from = mock(From.class);`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit c8196b5

File tree

2 files changed

2 files changed

`‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcSqlServerDialectTest.java‎`

`‎spring-data-relational/src/test/java/org/springframework/data/relational/core/dialect/SqlServerDialectUnitTests.java‎`

0 commit comments