Commit d732700

christophstroblschauder

authored and

committed

Deprecate background flag for creating indexes.

And fix type name in tests. See #5074 Original pull request #5085

1 parent 38dcb1a commit d732700Copy full SHA for d732700

File tree

+17

-4

lines changed

spring-data-mongodb/src
- main/java/org/springframework/data/mongodb/core/index
- test/java/org/springframework/data/mongodb/core/index
  - MongoPersistentEntityIndexResolverUnitTests.java

+17

-4

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -152,11 +152,15 @@`
`152`	`152`
`153`	`153`	`/**`
`154`	`154`	`* If {@literal true} the index will be created in the background.`
	`155`	`+ * <p>`
	`156`	`+ * <strong>NOTE:</strong> Since MongoDB 4.2 the background flag is ignored by the server if set.`
`155`	`157`	`*`
`156`	`158`	`* @return {@literal false} by default.`
`157`	`159`	`* @see <a href=`
`158`	`160`	`* "https://docs.mongodb.org/manual/core/indexes/#background-construction">https://docs.mongodb.org/manual/core/indexes/#background-construction</a>`
	`161`	`+ * @deprecated since 5.0 for removal without replacement.`
`159`	`162`	`*/`
	`163`	`+ @Deprecated(since = "5.0", forRemoval = true)`
`160`	`164`	`boolean background() default false;`
`161`	`165`
`162`	`166`	`/**`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -94,10 +94,15 @@ public Index sparse() {`
`94`	`94`
`95`	`95`	`/**`
`96`	`96`	`* Build the index in background (non blocking).`
	`97`	`+ * <p>`
	`98`	`+ * <strong>NOTE:</strong> Since MongoDB 4.2 the background flag is ignored by the server if set.`
`97`	`99`	`*`
`98`	`100`	`* @return this.`
`99`	`101`	`* @since 1.5`
`100`		`- */@Contract("-> this")`
	`102`	`+ * @deprecated since 5.0 for removal without replacement.`
	`103`	`+ */`
	`104`	`+ @Deprecated(since = "5.0", forRemoval = true)`
	`105`	`+ @Contract("-> this")`
`101`	`106`	`public Index background() {`
`102`	`107`
`103`	`108`	`this.background = true;`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -123,11 +123,15 @@`
`123`	`123`
`124`	`124`	`/**`
`125`	`125`	`* If {@literal true} the index will be created in the background.`
	`126`	`+ * <p>`
	`127`	`+ * <strong>NOTE:</strong> Since MongoDB 4.2 the background flag is ignored by the server if set.`
`126`	`128`	`*`
`127`	`129`	`* @return {@literal false} by default.`
	`130`	`+ * @deprecated since 5.0 for removal without replacement.`
`128`	`131`	`* @see <a href=`
`129`	`132`	`* "https://docs.mongodb.org/manual/core/indexes/#background-construction">https://docs.mongodb.org/manual/core/indexes/#background-construction</a>`
`130`	`133`	`*/`
	`134`	`+ @Deprecated(since = "5.0", forRemoval = true)`
`131`	`135`	`boolean background() default false;`
`132`	`136`
`133`	`137`	`/**`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -670,7 +670,7 @@ public void compoundIndexOnSuperClassResolvedCorrectly() {`
`670`	`670`	`public void compoundIndexDoesNotSpecifyNameWhenUsingGenerateName() {`
`671`	`671`
`672`	`672`	`List<IndexDefinitionHolder> indexDefinitions = prepareMappingContextAndResolveIndexForType(`
`673`		`- ComountIndexWithAutogeneratedName.class);`
	`673`	`+ CompoundIndexWithAutogeneratedName.class);`
`674`	`674`
`675`	`675`	`IndexDefinition indexDefinition = indexDefinitions.get(0).getIndexDefinition();`
`676`	`676`	`assertThat(indexDefinition.getIndexOptions())`
`@@ -835,10 +835,10 @@ class SingleCompoundIndex {}`
`835`	`835`
`836`	`836`	`class IndexDefinedOnSuperClass extends CompoundIndexOnLevelZero {}`
`837`	`837`
`838`		`- @Document("ComountIndexWithAutogeneratedName")`
	`838`	`+ @Document("CompoundIndexWithAutogeneratedName")`
`839`	`839`	`@CompoundIndexes({ @CompoundIndex(useGeneratedName = true, def = "{'foo': 1, 'bar': -1}", background = true,`
`840`	`840`	`sparse = true, unique = true) })`
`841`		`- class ComountIndexWithAutogeneratedName {}`
	`841`	`+ class CompoundIndexWithAutogeneratedName {}`
`842`	`842`
`843`	`843`	`@Document("WithComposedAnnotation")`
`844`	`844`	`@ComposedCompoundIndex`

Comments

(0)