Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 3bd196f

Browse files
Fix GatewayMetricsAutoConfiguration.
With the new spring-boot-micrometer-tracing MicrometerTracingAutoConfiguration may not be on the classpath so we should make the GatewayMetricsAutoConfiguration conditional on the classpath. Since spring-boot-micrometer-tracing is optional and spring-cloud-gateway-sample requires GatewayMetricsProperties we should add spring-boot-micrometer-tracing to the classpath for tests.
1 parent 384548b commit 3bd196f

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

‎spring-cloud-gateway-sample/pom.xml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,11 @@
9090
<artifactId>junit-platform-launcher</artifactId>
9191
<scope>test</scope>
9292
</dependency>
93+
<dependency>
94+
<groupId>org.springframework.boot</groupId>
95+
<artifactId>spring-boot-micrometer-tracing</artifactId>
96+
<scope>test</scope>
97+
</dependency>
9398
</dependencies>
9499
<build>
95100
<plugins>

‎spring-cloud-gateway-server-webflux/src/main/java/org/springframework/cloud/gateway/config/GatewayMetricsAutoConfiguration.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@
6262
@AutoConfigureBefore(HttpHandlerAutoConfiguration.class)
6363
@AutoConfigureAfter({ MetricsAutoConfiguration.class, CompositeMeterRegistryAutoConfiguration.class,
6464
ObservationAutoConfiguration.class, MicrometerTracingAutoConfiguration.class })
65-
@ConditionalOnClass({ DispatcherHandler.class, MeterRegistry.class, MetricsAutoConfiguration.class })
65+
@ConditionalOnClass({ DispatcherHandler.class, MeterRegistry.class, MetricsAutoConfiguration.class,
66+
MicrometerTracingAutoConfiguration.class })
6667
public class GatewayMetricsAutoConfiguration {
6768

6869
@Bean

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /