Commit f4ac407

committed

Refactor ObjectDriver to accept yamlConfig array in constructor and update serialization method to use it

1 parent e9a5f9c commit f4ac407Copy full SHA for f4ac407

File tree

+19

-7

lines changed

+19

-7

lines changed

Lines changed: 16 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,23 @@`
`12`	`12`
`13`	`13`	`class ObjectDriver implements Driver`
`14`	`14`	`{`
	`15`	`+ private const DEFAULT_YAML_CONFIG = [`
	`16`	`+ 'yaml_inline' => 2,`
	`17`	`+ 'yaml_indent' => 4,`
	`18`	`+ 'yaml_flags' => Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK,`
	`19`	`+ ];`
	`20`	`+`
	`21`	`+ /**`
	`22`	`+ * @param array{`
	`23`	`+ * yaml_inline: int,`
	`24`	`+ * yaml_indent: int,`
	`25`	`+ * yaml_flags: int`
	`26`	`+ * } $yamlConfig`
	`27`	`+ */`
`15`	`28`	`public function __construct(`
`16`		`- protected int$yamlInline = 2,`
	`29`	`+ protected array$yamlConfig = [],`
`17`	`30`	`) {`
	`31`	`+ $this->yamlConfig = array_merge(self::DEFAULT_YAML_CONFIG, $yamlConfig);`
`18`	`32`	`}`
`19`	`33`
`20`	`34`	`public function serialize($data): string`
`@@ -31,11 +45,7 @@ public function serialize($data): string`
`31`	`45`	`$serializer = new Serializer($normalizers, $encoders);`
`32`	`46`
`33`	`47`	`return $this->dedent(`
`34`		`- $serializer->serialize($data, 'yaml', [`
`35`		`- 'yaml_inline' => $this->yamlInline,`
`36`		`- 'yaml_indent' => 4,`
`37`		`- 'yaml_flags' => Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK,`
`38`		`- ])`
	`48`	`+ $serializer->serialize($data, 'yaml', $this->yamlConfig)`
`39`	`49`	`);`
`40`	`50`	`}`
`41`	`51`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,9 @@ public function it_can_serialize_a_class_instance()`
`92`	`92`	`#[Test]`
`93`	`93`	`public function it_can_serialize_with_custom_parameters()`
`94`	`94`	`{`
`95`		`- $driver = new ObjectDriver(3);`
	`95`	`+ $driver = new ObjectDriver([`
	`96`	`+ 'yaml_inline' => 3,`
	`97`	`+ ]);`
`96`	`98`
`97`	`99`	`$nestedObject = (object) [`
`98`	`100`	`'foo' => (object) [`

Comments

(0)