Commit 3919da8

danbevggerganov

authored and

committed

ggml : add check for grad_accs (ggml/1046)

* ggml : add check for grad_accs This commit adds a check for grad_accs in ggml_graph_get_grad and ggml_graph_get_grad_acc functions. This is necessary to avoid segfaults when grad_accs is not initialized. The motivation for this change is that I find it nice to be able to print out a computation graph using ggml_graph_print but this function segfaults when grad_accs is not initialized: ```console (gdb) p g1 2ドル = (ggml_cgraph *) 0x7ffff66004b0 (gdb) p *g1 3ドル = {size = 2048, n_nodes = 1, n_leafs = 2, nodes = 0x7ffff6600500, grads = 0x0, grad_accs = 0x0, leafs = 0x7ffff6604500, visited_hash_set = {size = 4099, used = 0x7ffff6610518, keys = 0x7ffff6608500}, order = GGML_CGRAPH_EVAL_ORDER_LEFT_TO_RIGHT} (gdb) p ggml_graph_print(g1) === GRAPH === n_nodes = 1 Program received signal SIGSEGV, Segmentation fault. 0x0000555555579775 in ggml_graph_get_grad (cgraph=0x7ffff66004b0,node=0x7ffff6600340) at /ggml/ggml/src/ggml.c:5990 5990 return igrad != GGML_HASHSET_FULL && ggml_bitset_get(cgraph->visited_hash_set.used, igrad) ? cgraph->grads[igrad] : NULL; ``` * squash! ggml : add check for grad_accs Fix the check in ggml_graph_get_grad. The check was incorrectly using cgraph->grad_accs instead of cgraph->grads.

1 parent 0006f5a commit 3919da8Copy full SHA for 3919da8

File tree

1 file changed

-2

lines changed

ggml/src
- ggml.c

1 file changed

-2

lines changed

`‎ggml/src/ggml.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6037,12 +6037,12 @@ struct ggml_tensor * ggml_graph_get_tensor(const struct ggml_cgraph * cgraph, co`
`6037`	`6037`
`6038`	`6038`	`struct ggml_tensor * ggml_graph_get_grad(const struct ggml_cgraph * cgraph, const struct ggml_tensor * node) {`
`6039`	`6039`	`const size_t igrad = ggml_hash_find(&cgraph->visited_hash_set, node);`
`6040`		`- return igrad != GGML_HASHSET_FULL && ggml_bitset_get(cgraph->visited_hash_set.used, igrad) ? cgraph->grads[igrad] : NULL;`
	`6040`	`+ return igrad != GGML_HASHSET_FULL && ggml_bitset_get(cgraph->visited_hash_set.used, igrad) &&cgraph->grads? cgraph->grads[igrad] : NULL;`
`6041`	`6041`	`}`
`6042`	`6042`
`6043`	`6043`	`struct ggml_tensor * ggml_graph_get_grad_acc(const struct ggml_cgraph * cgraph, const struct ggml_tensor * node) {`
`6044`	`6044`	`const size_t igrad = ggml_hash_find(&cgraph->visited_hash_set, node);`
`6045`		`- return igrad != GGML_HASHSET_FULL && ggml_bitset_get(cgraph->visited_hash_set.used, igrad) ? cgraph->grad_accs[igrad] : NULL;`
	`6045`	`+ return igrad != GGML_HASHSET_FULL && ggml_bitset_get(cgraph->visited_hash_set.used, igrad) &&cgraph->grad_accs? cgraph->grad_accs[igrad] : NULL;`
`6046`	`6046`	`}`
`6047`	`6047`
`6048`	`6048`	`void ggml_graph_print(const struct ggml_cgraph * cgraph) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 3919da8

File tree

1 file changed

1 file changed

`‎ggml/src/ggml.c‎`

0 commit comments