Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit b414752

Browse files
committed
[OPTIONAL] Composer: raise the minimum supported PHPCS version to 3.8.0
... to prevent end-users from running into trouble with the name change. The files in the Composer `vendor/bin` will only be replaced when the `replace...` directive is found and that is only available in the 3.8.0 tag. When the files in the Composer `vendor/bin` are not replaced, they will continue to point to the `vendor/squizlabs/php_codesniffer` directory which will no longer exist, leading to fatal "File not found" errors for end-users trying to run PHPCS/PHPCBF. Includes updating references to the PHPCS version whenever relevant throughout the codebase. Note: it should work fine without this change, but may lead to support requests.
1 parent cde71c8 commit b414752

File tree

3 files changed

+7
-27
lines changed

3 files changed

+7
-27
lines changed

‎.github/workflows/test.yml‎

Lines changed: 5 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -33,30 +33,10 @@ jobs:
3333
# - PHP 8.3 needs PHPCS 3.8.0+ to run without errors (though the errors don't affect this package).
3434
#
3535
# The matrix is set up so as not to duplicate the builds which are run for code coverage.
36-
php: ['5.5', '5.6', '7.0', '7.1', '7.2', '7.3']
37-
phpcs_version: ['3.5.6', 'dev-master']
36+
php: ['5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
37+
phpcs_version: ['3.8.0', 'dev-master']
3838

3939
include:
40-
# Make the matrix complete without duplicating builds run in code coverage.
41-
- php: '8.3'
42-
phpcs_version: '3.6.1'
43-
44-
- php: '8.2'
45-
phpcs_version: '3.6.1'
46-
47-
- php: '8.1'
48-
phpcs_version: 'dev-master'
49-
- php: '8.1'
50-
phpcs_version: '3.6.1'
51-
52-
- php: '8.0'
53-
phpcs_version: 'dev-master'
54-
- php: '8.0'
55-
phpcs_version: '3.5.7'
56-
57-
- php: '7.4'
58-
phpcs_version: 'dev-master'
59-
6040
# Experimental builds.
6141
- php: '8.4' # Nightly.
6242
phpcs_version: 'dev-master'
@@ -127,13 +107,13 @@ jobs:
127107
include:
128108
- php: '8.3'
129109
phpcs_version: 'dev-master'
130-
- php: '7.4'
131-
phpcs_version: '3.5.6'
110+
- php: '8.3'
111+
phpcs_version: '3.8.0'
132112

133113
- php: '5.4'
134114
phpcs_version: 'dev-master'
135115
- php: '5.4'
136-
phpcs_version: '3.5.6'
116+
phpcs_version: '3.8.0'
137117

138118
name: "Coverage: PHP ${{ matrix.php }} on PHPCS ${{ matrix.phpcs_version }}"
139119

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Plugin for PHP_CodeSniffer static analysis tool that adds analysis of problemati
1515

1616
### Requirements
1717

18-
VariableAnalysis requires PHP 5.4 or higher and [PHP CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) version 3.5.6 or higher.
18+
VariableAnalysis requires PHP 5.4 or higher and [PHP CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) version 3.8.0 or higher.
1919

2020
### With PHPCS Composer Installer
2121

‎composer.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
},
4949
"require" : {
5050
"php" : ">=5.4.0",
51-
"phpcsstandards/php_codesniffer": "^3.5.6"
51+
"phpcsstandards/php_codesniffer": "^3.8.0"
5252
},
5353
"require-dev": {
5454
"phpunit/phpunit": "^4.8.36 || ^5.7.21 || ^6.5 || ^7.0 || ^8.0 || ^9.0",

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /