Commit 4a998c5

committed

Correctly detect that a module is test suite

Instead of relying on module name to start with "test" (which is not required neither by UnitTest docs nor by implementation) we now inspect its source code and check if LibPQ UnitTest metadata field is mentioned.

1 parent 809d6dc commit 4a998c5Copy full SHA for 4a998c5

File tree

1 file changed

-2

lines changed

Modules
- UnitTest.Discover.pq

1 file changed

-2

lines changed

`‎Modules/UnitTest.Discover.pq‎`

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,12 +33,17 @@ let`
`33`	`33`	`),`
`34`	`34`	`LooksLikeSuiteWithError = (name, object) =>`
`35`	`35`	`let`
`36`		`- NameLikeTest = Text.StartsWith(name, Config[Test.Prefix], Comparer.OrdinalIgnoreCase),`
	`36`	`+ ModuleFilename = object[Detail][LibPQ][LibPQ.Source], // error record is assumed`
	`37`	`+ Read.Text = LibPQ("Read.Text"),`
	`38`	`+ ModuleSource = Read.Text(ModuleFilename, true),`
	`39`	`+ ModuleIsTestSuite = Text.Contains(ModuleSource, Config[Suite.MetaField]),`
`37`	`40`	`ObjLikeError =`
`38`	`41`	`Value.Is(object, type record)`
`39`	`42`	`and Record.FieldCount(object) = 3`
`40`	`43`	`and Record.FieldNames(object) = {"Reason", "Message", "Detail"},`
`41`		`- Return = NameLikeTest and ObjLikeError`
	`44`	`+ Return = ObjLikeError and ModuleIsTestSuite // Order matters for short circuiting.`
	`45`	`+ // ModuleIsTestSuite assumes that`
	`46`	`+ // object is an error record`
`42`	`47`	`in`
`43`	`48`	`Return,`
`44`	`49`	`PropagateErrors = (suite) =>`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 4a998c5

File tree

1 file changed

1 file changed

`‎Modules/UnitTest.Discover.pq‎`

0 commit comments