Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

update to 16 rc2 #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justin808 wants to merge 3 commits into master from update-react-on-rails-16.0.1-rc.0-try-2
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert to React on Rails 14.2.1 to ensure CI passes 
This reverts the upgrade to React on Rails 16.0.1.rc.2 due to breaking changes:
1. Server bundle path resolution regression - React on Rails 16 looks for bundles in
 /public/webpack/test/ but Shakapacker 8.0.0 outputs to /public/packs/
2. ReScript compatibility issues - rescript-react-on-rails only supports React on Rails v10
The ReScript components have been temporarily disabled by commenting out imports
and registrations in both client-bundle.js and server-bundle.js.
This establishes a stable baseline for systematic upgrades:
- Next: Upgrade Shakapacker to 8.4 (separate PR)
- Then: Upgrade React on Rails to 16.x with proper compatibility
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
  • Loading branch information
justin808 and claude committed Sep 21, 2025
commit 855f99ffdc5d16f12f48309e86fd4d91f9a961a3
2 changes: 1 addition & 1 deletion Gemfile
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby "3.3.4"

gem "react_on_rails", "16.0.1.rc.2"
gem "react_on_rails", "14.2.1"
gem "shakapacker", "8.0.0"

# Bundle edge Rails instead: gem "rails", github: "rails/rails"
Expand Down
5 changes: 2 additions & 3 deletions Gemfile.lock
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,13 +317,12 @@ GEM
rdoc (6.14.2)
erb
psych (>= 4.0.0)
react_on_rails (16.0.1.rc.2)
react_on_rails (14.2.1)
addressable
connection_pool
execjs (~> 2.5)
rails (>= 5.2)
rainbow (~> 3.0)
shakapacker (>= 6.0)
redcarpet (3.6.1)
redis (5.4.1)
redis-client (>= 0.22.0)
Expand Down Expand Up @@ -507,7 +506,7 @@ DEPENDENCIES
rails-html-sanitizer
rails_best_practices
rainbow
react_on_rails (= 16.0.1.rc.2)
react_on_rails (= 14.2.1)
redcarpet
redis (~> 5.0)
rspec-rails (~> 6.0.0)
Expand Down
4 changes: 2 additions & 2 deletions client/app/packs/client-bundle.js
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import routerCommentsStore from '../bundles/comments/store/routerCommentsStore';
import commentsStore from '../bundles/comments/store/commentsStore';
import NavigationBarApp from '../bundles/comments/startup/NavigationBarApp';
import Footer from '../bundles/comments/components/Footer/Footer';
import RescriptShow from '../bundles/comments/rescript/ReScriptShow.bs.js';
// import RescriptShow from '../bundles/comments/rescript/ReScriptShow.bs.js';

import '../assets/styles/application';

Expand All @@ -26,7 +26,7 @@ ReactOnRails.register({
NavigationBarApp,
SimpleCommentScreen,
Footer,
RescriptShow,
// RescriptShow,
});

ReactOnRails.registerStore({
Expand Down
4 changes: 2 additions & 2 deletions client/app/packs/server-bundle.js
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ import NavigationBarApp from '../bundles/comments/startup/NavigationBarApp';
import routerCommentsStore from '../bundles/comments/store/routerCommentsStore';
import commentsStore from '../bundles/comments/store/commentsStore';
import Footer from '../bundles/comments/components/Footer/Footer';
import RescriptShow from '../bundles/comments/rescript/ReScriptShow.bs.js';
// import RescriptShow from '../bundles/comments/rescript/ReScriptShow.bs.js';

ReactOnRails.register({
App,
RouterApp,
NavigationBarApp,
SimpleCommentScreen,
Footer,
RescriptShow,
// RescriptShow,
});

ReactOnRails.registerStore({
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@babel/preset-react": "^7.18.6",
"@babel/runtime": "^7.17.9",
"@glennsl/rescript-fetch": "^0.2.0",
"@glennsl/rescript-json-combinators": "^1.2.1",
"@glennsl/rescript-json-combinators": "^1.4.0",
"@hotwired/stimulus": "^3.2.1",
"@hotwired/stimulus-webpack-helpers": "^1.0.1",
"@hotwired/turbo-rails": "^7.3.0",
Expand Down Expand Up @@ -78,7 +78,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"react-intl": "^6.4.4",
"react-on-rails": "16.0.1-rc.2",
"react-on-rails": "14.2.1",
"react-redux": "^8.1.0",
"react-router": "^6.13.0",
"react-router-dom": "^6.13.0",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,7 +1346,7 @@
resolved "https://registry.npmjs.org/@glennsl/rescript-fetch/-/rescript-fetch-0.2.3.tgz#99ab3c2a9c87fcc301d71e906f8cd476a2a17321"
integrity sha512-0MuaXeJHGii0/SKzR4ASB1Wal+ogdnNsD1K6HSTFUVc+TQzAZY+V8Nb7Z8K4OUqMJzmurIgVXNmirx3DC1Huyg==

"@glennsl/rescript-json-combinators@^1.2.1":
"@glennsl/rescript-json-combinators@^1.4.0":
version "1.4.0"
resolved "https://registry.npmjs.org/@glennsl/rescript-json-combinators/-/rescript-json-combinators-1.4.0.tgz#3d4be72870a99be737e2121fb86d30ccc9d4ca45"
integrity sha512-tIhAJoAqyfF3Mbd66Koipl6WZxLKJTJFHTx99jDG5+YAv/Hr6XrXYryCXs1Qi8BWUwx5WQcgKay3lUzElUYC7Q==
Expand Down Expand Up @@ -7673,10 +7673,10 @@ react-is@^18.0.0:
resolved "https://registry.npmjs.org/react-is/-/react-is-18.3.1.tgz#e83557dc12eae63a99e003a46388b1dcbb44db7e"
integrity sha512-/LLMVyas0ljjAtoYiPqYiL8VWXzUUdThrmU5+n20DZv+a+ClRoevUzw5JxU+Ieh5/c87ytoTBV9G1FiKfNJdmg==

react-on-rails@16.0.1-rc.2:
version "16.0.1-rc.2"
resolved "https://registry.npmjs.org/react-on-rails/-/react-on-rails-16.0.1-rc.2.tgz#efa95be66173f7653d954271005a38814cbb6065"
integrity sha512-A4aiSqoFpebpFlW5aFf0+vm+icFazO6PHmyvs9PdEfvgSwvFfakvYZ132hrNsZmHdHB+nl8C+xg0gFxG7lMmfA==
react-on-rails@14.2.1:
version "14.2.1"
resolved "https://registry.npmjs.org/react-on-rails/-/react-on-rails-14.2.1.tgz#e3072f21bb76a45de789fc78046d2bf0d9496878"
integrity sha512-1a7RCDzhM2/oAZChnJMcYDV023Gl6nwa5SAS+NW13jIpkigihiRw2ecYAFSjQq2BfCnASDw2z1ElmfTXhrYagw==

react-proxy@^1.1.7:
version "1.1.8"
Expand Down
Loading

AltStyle によって変換されたページ (->オリジナル) /