Commit cd1cc08

committed

test: Sort completion results items

It seems there is some behaviour differences regarding the order completions are returned in between linux and macos, specifically regarding sorting of upper case and lowercase letters. Sorting them ourselves in the tests makes it consistent.

1 parent 81d732d commit cd1cc08Copy full SHA for cd1cc08

File tree

2 files changed

-3

lines changed

test/t
- conftest.py
- unit
  - test_unit_dequote.py

2 files changed

-3

lines changed

`‎test/t/conftest.py‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -773,7 +773,7 @@ def startswith(self, prefix: str) -> bool:`
`773`	`773`	`return self.output.startswith(prefix)`
`774`	`774`
`775`	`775`	`def _items(self) -> List[str]:`
`776`		`- return [x.strip() for x in self.output.strip().splitlines()]`
	`776`	`+ return sorted([x.strip() for x in self.output.strip().splitlines()])`
`777`	`777`
`778`	`778`	`def __eq__(self, expected: object) -> bool:`
`779`	`779`	`"""`
`@@ -788,7 +788,7 @@ def __eq__(self, expected: object) -> bool:`
`788`	`788`	`return False`
`789`	`789`	`else:`
`790`	`790`	`expiter = expected`
`791`		`- return self._items() == expiter`
	`791`	`+ return self._items() == sorted(expiter)`
`792`	`792`
`793`	`793`	`def __contains__(self, item: str) -> bool:`
`794`	`794`	`return item in self._items()`

`‎test/t/unit/test_unit_dequote.py‎`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+import re`
	`2`	`+`
`1`	`3`	`import pytest`
`2`	`4`
`3`	`5`	`from conftest import assert_bash_exec, bash_env_saved`
`@@ -38,7 +40,8 @@ def test_5_brace(self, bash, functions):`
`38`	`40`
`39`	`41`	`def test_6_glob(self, bash, functions):`
`40`	`42`	`output = assert_bash_exec(bash, "__tester 'a?b'", want_output=True)`
`41`		`- assert output.strip() == "<a b><a$b><a&b><a'b>"`
	`43`	`+ items = sorted(re.findall(r"<[^>]*>", output))`
	`44`	`+ assert "".join(items) == "<a b><a$b><a&b><a'b>"`
`42`	`45`
`43`	`46`	`def test_7_quote_1(self, bash, functions):`
`44`	`47`	`output = assert_bash_exec(`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit cd1cc08

File tree

2 files changed

2 files changed

`‎test/t/conftest.py‎`

`‎test/t/unit/test_unit_dequote.py‎`

0 commit comments