Commit 7d8be19

committed

Introduce -Yreporter

1 parent 361a4f3 commit 7d8be19Copy full SHA for 7d8be19

File tree

+16

-7

lines changed

+16

-7

lines changed

Lines changed: 13 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -84,17 +84,26 @@ class Driver {`
`84`	`84`	`MacroClassLoader.init(ictx)`
`85`	`85`	`Positioned.init(using ictx)`
`86`	`86`
`87`		`- inContext(ictx) {`
	`87`	`+ inContext(ictx):`
`88`	`88`	`if !ctx.settings.XdropComments.value \|\| ctx.settings.XreadComments.value then`
`89`	`89`	`ictx.setProperty(ContextDoc, new ContextDocstrings)`
`90`	`90`	`val fileNamesOrNone = command.checkUsage(summary, sourcesRequired)(using ctx.settings)(using ctx.settingsState)`
`91`	`91`	`fileNamesOrNone.map: fileNames =>`
`92`	`92`	`val files = fileNames.map(ctx.getFile)`
`93`	`93`	`(files, fromTastySetup(files))`
`94`	`94`	`.tap: _ =>`
`95`		`- if ctx.settings.YnoReporter.value then`
`96`		`- ictx.setReporter(Reporter.SilentReporter())`
`97`		`- }`
	`95`	`+ if !ctx.settings.Yreporter.isDefault then`
	`96`	`+ ctx.settings.Yreporter.value match`
	`97`	`+ case "help" =>`
	`98`	`+ case reporterClassName =>`
	`99`	`+ try`
	`100`	`+ Class.forName(reporterClassName).getDeclaredConstructor().newInstance() match`
	`101`	`+ case userReporter: Reporter =>`
	`102`	`+ ictx.setReporter(userReporter)`
	`103`	`+ case badReporter => report.error:`
	`104`	`+ em"Not a reporter: ${ctx.settings.Yreporter.value}"`
	`105`	`+ catch case e: ReflectiveOperationException => report.error:`
	`106`	`+ em"Could not create reporter ${ctx.settings.Yreporter.value}: ${e}"`
`98`	`107`	`}`
`99`	`108`
`100`	`109`	`/** Setup extra classpath of tasty and jar files */`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ private sealed trait YSettings:`
`397`	`397`	`val YdisableFlatCpCaching: Setting[Boolean] = BooleanSetting(ForkSetting, "YdisableFlatCpCaching", "Do not cache flat classpath representation of classpath elements from jars across compiler instances.")`
`398`	`398`	`val YnoStdlibPatches: Setting[Boolean] = BooleanSetting(ForkSetting, "Yno-stdlib-patches", "Do not patch stdlib files (temporary and only to be used for the stdlib migration)", false)`
`399`	`399`
`400`		`- val YnoReporter: Setting[Boolean] = BooleanSetting(ForkSetting, "Yno-reporter", "Diagnostics are silently consumed")`
	`400`	`+ val Yreporter: Setting[String] = StringSetting(ForkSetting, name ="Yreporter", helpArg ="<class>", descr ="Specify a dotty.tools.dotc.reporting.Reporter", default ="dotty.tools.dotc.reporting.ConsoleReporter")`
`401`	`401`
`402`	`402`	`val Yscala2Unpickler: Setting[String] = StringSetting(ForkSetting, "Yscala2-unpickler", "", "Control where we may get Scala 2 symbols from. This is either \"always\", \"never\", or a classpath.", "always")`
`403`	`403`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ object Reporter {`
`30`	`30`	`override def report(dia: Diagnostic)(using Context): Unit = ()`
`31`	`31`	`}`
`32`	`32`
`33`		`- /** A reporter for -Yno-reporter [sic] */`
	`33`	`+ /** A silent reporter for testing */`
`34`	`34`	`class SilentReporter extends Reporter:`
`35`	`35`	`def doReport(dia: Diagnostic)(using Context): Unit = ()`
`36`	`36`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ class SemanticdbTests:`
`144`	`144`	`"-Xignore-scala2-macros",`
`145`	`145`	`"-usejavacp",`
`146`	`146`	`"-Wunused:all",`
`147`		`- "-Yno-reporter",`
	`147`	`+ "-Yreporter:dotty.tools.dotc.reporting.Reporter$SilentReporter",`
`148`	`148`	`) ++ inputFiles().map(_.toString)`
`149`	`149`	`val exit = Main.process(args)`
`150`	`150`	`assertFalse(s"dotc errors: ${exit.errorCount}", exit.hasErrors)`

Comments

(0)