Commit 19cf3fc

committed

Drop the isExplicit type and hasExplicitType logic

1 parent 822277e commit 19cf3fcCopy full SHA for 19cf3fc

File tree

2 files changed

-9

lines changed

compiler/src/dotty/tools/dotc
- core
  - SymDenotations.scala
- typer
  - Namer.scala

2 files changed

-9

lines changed

`‎compiler/src/dotty/tools/dotc/core/SymDenotations.scala‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2799,9 +2799,6 @@ object SymDenotations {`
`2799`	`2799`	`/** Sets all missing fields of given denotation */`
`2800`	`2800`	`def complete(denot: SymDenotation)(using Context): Unit`
`2801`	`2801`
`2802`		`- /** Is this a completer for an explicit type tree */`
`2803`		`- def isExplicit: Boolean = false`
`2804`		`-`
`2805`	`2802`	`def apply(sym: Symbol): LazyType = this`
`2806`	`2803`	`def apply(module: TermSymbol, modcls: ClassSymbol): LazyType = this`
`2807`	`2804`

`‎compiler/src/dotty/tools/dotc/typer/Namer.scala‎`

Lines changed: 1 addition & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -280,9 +280,6 @@ class Namer { typer: Typer =>`
`280`	`280`	`if rhs.isEmpty \|\| flags.is(Opaque) then flags \|= Deferred`
`281`	`281`	`if flags.is(Param) then tree.rhs else analyzeRHS(tree.rhs)`
`282`	`282`
`283`		`- def hasExplicitType(tree: ValOrDefDef): Boolean =`
`284`		`- !tree.tpt.isEmpty \|\| tree.mods.isOneOf(TermParamOrAccessor)`
`285`		`-`
`286`	`283`	`// to complete a constructor, move one context further out -- this`
`287`	`284`	`// is the context enclosing the class. Note that the context in which a`
`288`	`285`	`// constructor is recorded and the context in which it is completed are`
`@@ -296,8 +293,6 @@ class Namer { typer: Typer =>`
`296`	`293`
`297`	`294`	`val completer = tree match`
`298`	`295`	`case tree: TypeDef => TypeDefCompleter(tree)(cctx)`
`299`		`- case tree: ValOrDefDef if Feature.enabled(Feature.modularity) && hasExplicitType(tree) =>`
`300`		`- new Completer(tree, isExplicit = true)(cctx)`
`301`	`296`	`case _ => Completer(tree)(cctx)`
`302`	`297`	`val info = adjustIfModule(completer, tree)`
`303`	`298`	`createOrRefine[Symbol](tree, name, flags, ctx.owner, _ => info,`
`@@ -813,7 +808,7 @@ class Namer { typer: Typer =>`
`813`	`808`	`}`
`814`	`809`
`815`	`810`	`/** The completer of a symbol defined by a member def or import (except ClassSymbols) */`
`816`		`- class Completer(val original: Tree, overridevalisExplicit:Boolean=false)(ictx: Context) extends LazyType with SymbolLoaders.SecondCompleter {`
	`811`	`+ class Completer(val original: Tree)(ictx: Context) extends LazyType with SymbolLoaders.SecondCompleter {`
`817`	`812`
`818`	`813`	`protected def localContext(owner: Symbol): FreshContext = ctx.fresh.setOwner(owner).setTree(original)`
`819`	`814`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 19cf3fc

File tree

2 files changed

2 files changed

`‎compiler/src/dotty/tools/dotc/core/SymDenotations.scala‎`

`‎compiler/src/dotty/tools/dotc/typer/Namer.scala‎`

0 commit comments