-
Notifications
You must be signed in to change notification settings - Fork 435
Add the irq crate
#245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the irq crate
#245
Conversation
rust-highfive
commented
Jan 26, 2020
(rust_highfive has picked a reviewer for you, use r? to override)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
bors does not check reviews for commands, only normal comments
I'm sure bors does or used to check review comments for commands, it's how I've almost always r+'d PRs. Has it changed recently?
bors r=andre-richter
245: Add the `irq` crate r=andre-richter a=jonas-schievink Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Yup done it this way since a long time. Strange...
bors r+
Already running a review
Huh, weird
Build succeeded
If anyone is investigating, I also wonder if Github could have changed the way bors "sees" comments that originate from review comments. Ill do separate review and bors steps from now on though.
Looks like it's already filed: bors-ng/bors-ng#855
No description provided.