-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add "Prefer freeze_time over travel_to with an argument of the current time" rule
#318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is worth mentioning that freeze_time just delegates to travel_to with a default Time.now (https://github.com/rails/rails/blob/aa3a6c9c1b70e49bef5a2713aae96179debdff3e/activesupport/lib/active_support/testing/time_helpers.rb#L237):
def freeze_time(&block) travel_to Time.now, &block end
andyw8
andyw8
reviewed
Jun 14, 2022
andyw8
andyw8
reviewed
Jun 14, 2022
...rrent time" rule Since there are several ways to indicate the current time, we believe that `freeze_time`, which can be expressed as simply as possible, should be preferred. ```ruby # bad travel_to(Time.now) travel_to(DateTime.now) travel_to(Time.current) travel_to(Time.zone.now) travel_to(Time.now.in_time_zone) travel_to(Time.current.to_time) # good freeze_time ```
@ydah
ydah
force-pushed
the
add_freeze_time_rule
branch
from
June 14, 2022 13:06
e97790e to
3cb6abe
Compare
@ydah
ydah
changed the title
(削除) Add "Prefer
(追記) Add "Prefer Jun 14, 2022
freeze_time over travel_to with argument current time" rule (削除ここまで)freeze_time over travel_to with an argument of the current time" rule (追記ここまで)
andyw8
andyw8
approved these changes
Jun 14, 2022
8 tasks
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are several ways to indicate the current time, we believe that
freeze_time, which can be expressed as simply as possible, should be preferred.