-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add recording of shadow DOM nodes which have been created with the { mode: 'closed' } flag #1739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
... mode:closed shadow roots, and record them just like open ones
🦋 Changeset detected
Latest commit: 5889179
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
If a reviewer dislikes the addition of __rrClosedShadowRoot attributes on elements with closed shadow roots, the remedy would be to move dom.shadowRoot to ShadowDomManager.shadowRoot and pass a reference to shadowDomManager into the rrweb-snapshot/snapshot.ts serialization.
Leverage monkeypatching on
addShadowRootto save a reference to the mode:closed shadow roots, and record them just like open ones