Commit 4f53362

authored

Remove static markup from NodeStreamRenderer

The API docs did not match the actual behaviour. htmlStart & htmlEnd should be variables that can be passed to the function, currently they are static defined in the function.

1 parent 3ecacab commit 4f53362Copy full SHA for 4f53362

File tree

1 file changed

-11

lines changed

src/server
- ReactDOMNodeStreamRenderer.js

1 file changed

-11

lines changed

`‎src/server/ReactDOMNodeStreamRenderer.js‎`

Lines changed: 2 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -99,12 +99,7 @@ function originalRenderToNodeStream(element, cache, streamingStart, memLife=0) {`
`99`	`99`	`return new ReactMarkupReadableStream(element, false, cache, streamingStart, memLife);`
`100`	`100`	`}`
`101`	`101`
`102`		`-export function renderToNodeStream(element, cache, res) {`
`103`		`-`
`104`		`- const htmlStart =`
`105`		`- '<html><head><title>Page</title></head><body><div id="react-root">';`
`106`		`-`
`107`		`- const htmlEnd = '</div></body></html>';`
	`102`	`+export function renderToNodeStream(element, cache, res, htmlStart, htmlEnd) {`
`108`	`103`
`109`	`104`	`const streamingStart = {`
`110`	`105`	`sliceStartCount: htmlStart.length,`
`@@ -131,11 +126,7 @@ function originalRenderToStaticNodeStream(element, cache, streamingStart, memLif`
`131`	`126`	`return new ReactMarkupReadableStream(element, true, cache, streamingStart, memLife);`
`132`	`127`	`}`
`133`	`128`
`134`		`-export function renderToStaticNodeStream(element, cache, res) {`
`135`		`- const htmlStart =`
`136`		`- '<html><head><title>Page</title></head><body><div id="react-root">';`
`137`		`-`
`138`		`- const htmlEnd = '</div></body></html>';`
	`129`	`+export function renderToStaticNodeStream(element, cache, res, htmlStart, htmlEnd) {`
`139`	`130`
`140`	`131`	`const streamingStart = {`
`141`	`132`	`sliceStartCount: htmlStart.length,`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 4f53362

File tree

1 file changed

1 file changed

`‎src/server/ReactDOMNodeStreamRenderer.js‎`

0 commit comments