Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Improve stack and material top tabs #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoOx merged 2 commits into rescript-react-native:main from reck753:improve-stack-and-material-top-tabs
Apr 13, 2022
Merged

Improve stack and material top tabs #51

MoOx merged 2 commits into rescript-react-native:main from reck753:improve-stack-and-material-top-tabs
Apr 13, 2022

Conversation

@reck753
Copy link
Contributor

@reck753 reck753 commented Jan 10, 2022

Hi!

I improved Stack binding by adding:

  • headerBackTestID option
  • getId screen prop
    and improved MaterialTopTabs by adding swipeEnabled screen option since setting it through props is deprecated.

@MoOx MoOx requested a review from Freddy03h January 14, 2022 17:47
Copy link
Member

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice!

reck753 reacted with thumbs up emoji
Copy link
Contributor Author

reck753 commented Jan 14, 2022

Thanks, nice!

You are welcome!

@MoOx, I know it is not the best place to ask, but could you check svg and webview bindings? I have some PRs open there. svg PR is nothing much, while webview is a bit bigger change, more like a proposition.
Thanks!

@MoOx MoOx merged commit b77432d into rescript-react-native:main Apr 13, 2022
Copy link
Member

MoOx commented Apr 13, 2022

Sorry for this horrible delay. Thanks for you contributions. Do not hesitate to ping me more next time :)
Freddy03h and reck753 reacted with thumbs up emoji

Copy link
Contributor Author

reck753 commented Apr 16, 2022

No problem! You are welcome!

@reck753 reck753 deleted the improve-stack-and-material-top-tabs branch April 16, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoOx MoOx MoOx approved these changes

@Freddy03h Freddy03h Awaiting requested review from Freddy03h

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /