Commit 5e219c3

committed

SimpleRichTextEditor: Always update _currentValue after setState (as long as contentState has changed)

1 parent fc0298d commit 5e219c3Copy full SHA for 5e219c3

File tree

-5

lines changed

-5

lines changed

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,17 +66,16 @@ export default class SimpleRichTextEditor extends Component {`
`66`	`66`	`let {format, onChange} = this.props;`
`67`	`67`	`let oldEditorValue = this.state.editorValue;`
`68`	`68`	`this.setState({editorValue});`
`69`		`- if (onChange == null) {`
`70`		`- return;`
`71`		`- }`
`72`	`69`	`let oldContentState = oldEditorValue ? oldEditorValue.getEditorState().getCurrentContent() : null;`
`73`	`70`	`let newContentState = editorValue.getEditorState().getCurrentContent();`
`74`	`71`	`if (oldContentState !== newContentState) {`
`75`	`72`	`let stringValue = editorValue.toString(format);`
`76`		`- // Optimization so when onChange passes us new props we don't need`
	`73`	`+ // Optimization so if we receive new props we don't need`
`77`	`74`	`// to parse anything unnecessarily.`
`78`	`75`	`this._currentValue = [format, stringValue];`
`79`		`- onChange(stringValue);`
	`76`	`+ if (onChange) {`
	`77`	`+ onChange(stringValue);`
	`78`	`+ }`
`80`	`79`	`}`
`81`	`80`	`}`
`82`	`81`	`}`

Comments

(0)