Commit 4bceb5a

committed

refactor(select): improve keyboard and events, split native to SelectNative

BREAKING CHANGE: Select props changed significantly, native is now the SelectNative component

1 parent 664a86f commit 4bceb5aCopy full SHA for 4bceb5a

File tree

+1845

-797

lines changed

+1845

-797

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@`
`33`	`33`	`"access": "public"`
`34`	`34`	`},`
`35`	`35`	`"scripts": {`
`36`		`- "start": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true start-storybook -p 9009",`
	`36`	`+ "start": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true start-storybook -p 9009 --no-open",`
`37`	`37`	`"build:storybook": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true build-storybook -o ./storybook",`
`38`	`38`	`"build": "rm -rf dist && yarn run build:prod",`
`39`	`39`	`"build:dev": "cross-env NODE_ENV=development rollup -c",`
`@@ -82,6 +82,7 @@`
`82`	`82`	`"@storybook/react": "6.5.10",`
`83`	`83`	`"@testing-library/jest-dom": "^5.16.4",`
`84`	`84`	`"@testing-library/react": "^12.1.5",`
	`85`	`+ "@testing-library/react-hooks": "^8.0.1",`
`85`	`86`	`"@types/jest": "^28.1.6",`
`86`	`87`	`"@types/react": "^18.0.15",`
`87`	`88`	`"@types/react-dom": "^18.0.6",`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ import { Button } from '../Button/Button';`
`5`	`5`	`import { NumberInput } from '../NumberInput/NumberInput';`
`6`	`6`	`import { ScrollView } from '../ScrollView/ScrollView';`
`7`	`7`	`import { Select } from '../Select/Select';`
`8`		`-import { SelectChangeEvent } from '../Select/Select.types';`
`9`	`8`	`import { Toolbar } from '../Toolbar/Toolbar';`
`10`	`9`	`import { Window, WindowContent, WindowHeader } from '../Window/Window';`
`11`	`10`
`@@ -101,9 +100,12 @@ const DatePicker = forwardRef<HTMLDivElement, DatePickerProps>(`
`101`	`100`	`const [date, setDate] = useState(() => convertDateToState(initialDate));`
`102`	`101`	`const { year, month, day } = date;`
`103`	`102`
`104`		`- const handleMonthSelect = useCallback((e: SelectChangeEvent<number>) => {`
`105`		`- setDate(currentDate => ({ ...currentDate, month: e.target.value }));`
`106`		`- }, []);`
	`103`	`+ const handleMonthSelect = useCallback(`
	`104`	`+ ({ value: monthSelected }: { value: number }) => {`
	`105`	`+ setDate(currentDate => ({ ...currentDate, month: monthSelected }));`
	`106`	`+ },`
	`107`	`+ []`
	`108`	`+ );`
`107`	`109`
`108`	`110`	`const handleYearSelect = useCallback((yearSelected: number) => {`
`109`	`111`	`setDate(currentDate => ({ ...currentDate, year: yearSelected }));`

Comments

(0)