Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bug fix/cross button #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyushdevOP wants to merge 12 commits into react-native-elements:master
base: master
Choose a base branch
Loading
from piyushdevOP:bugFix/crossButton

Conversation

@piyushdevOP
Copy link

@piyushdevOP piyushdevOP commented Mar 28, 2021

What kind of change does this PR introduce?

Bug Fix

Did you add tests for your changes?
No.
If relevant, did you update the documentation?
Not Required
Summary
This PR fixes the crossButton bug in Input page. The cross button now clears the input text.
Fixes Issue #70

Does this PR introduce a breaking change?
Not Applicable

Other information

Copy link

netlify bot commented Mar 28, 2021
edited
Loading

Deploy preview for rne-playground ready!

Built with commit a334386

https://deploy-preview-104--rne-playground.netlify.app

Copy link
Author

Issue #70

crossButtonIssue.mov

Fixed #104

crossButtonFixed.mov

@ARJUN-SABU @ankushdutt @pranshuchittora @Uyadav207 Please look into it. This PR fixes issue #70 .

package.json Outdated
"react-scripts": "3.4.1",
"react-view": "^2.3.2"
"react-view": "^2.3.2",
"v8": "^0.1.0"
Copy link
Member

@pranshuchittora pranshuchittora Apr 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

<meta property="og:type" content="website" />
<meta property="og:url" content="https://react-native-elements.js.org/" />
<meta property="og:title" content="Playground 🚀 | React Native Elements" />
<meta property="og:title" content="Playground | React Native Elements" />
Copy link
Member

@pranshuchittora pranshuchittora Apr 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Author

@piyushdevOP piyushdevOP Apr 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Pranshu , I will undo this right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pranshuchittora pranshuchittora pranshuchittora left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /