-
Notifications
You must be signed in to change notification settings - Fork 16
Add Support for patches in nightly #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I added a patch for react native reanimated (babel.config.js changes required by worklets).
There is a script for make-patch and apply-patch which can be used to create and apply patch respectively.
@cortinico Can you please have a look here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I've left some nits but overall looks great
I have addressed the following issue.
- I have added firebase app which actual requires a pod file change to use frameworks. Now the build succeeds. 🚀. We can close this PR (libraries: add
@react-native-firebase/app#17 ) - Now if patch file is wrong . The pipeline ends .
- I did a minor change in MMKV . Basically added mrousavy as maintainer so that a non patch library can run and I can verify I havent broken anything :P.
cc:- @cortinico
That's great @riteshshukla04 thank you very much for adding this 🙏
59f01d1
into
react-native-community:main
This adds supports for patch file. Library maintainers can submit the patch file to modify template (if library requires changes in podfile, build.gradle, manifest etc.)