Commit 31b634b

authored

fix: move prefab headers inside JavaScriptCore folder (#186)

# Why following up facebook/react-native#47972 (comment) # How move prefab headers into `JavaScriptCore/` directory, so that `#include <JavaScriptCore/JavaScript.h>` in JSCRuntime will not break. this also simulates how JavaScriptCore.framework works.

1 parent 9c61fec commit 31b634bCopy full SHA for 31b634b

File tree

1 file changed

+13

-1

lines changed

lib/jsc-android
- build.gradle

1 file changed

+13

-1

lines changed

`‎lib/jsc-android/build.gradle‎`

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@ def i18n = project.findProperty("i18n") ?: ""`
`11`	`11`	`def signingKey = project.findProperty('signingKey')`
`12`	`12`	`def signingPassword = project.findProperty('signingPassword')`
`13`	`13`
	`14`	`+def prefabHeadersDir = "${buildDir}/prefab-headers"`
	`15`	`+`
`14`	`16`	`if (!distDir) throw new RuntimeException("expecting --project-prop distDir=??? but was empty")`
`15`	`17`	`if (!jniLibsDir) throw new RuntimeException("expecting --project-prop jniLibsDir=??? but was empty")`
`16`	`18`	`if (!version) throw new RuntimeException("expecting --project-prop version=??? but was empty")`
`@@ -56,7 +58,7 @@ android {`
`56`	`58`
`57`	`59`	`prefab {`
`58`	`60`	`jsc {`
`59`		`- headers file(headersDir).absolutePath`
	`61`	`+ headers file(prefabHeadersDir).absolutePath`
`60`	`62`	`}`
`61`	`63`	`}`
`62`	`64`
`@@ -72,7 +74,17 @@ project.group = "io.github.react-native-community"`
`72`	`74`	`def artifactName = Boolean.valueOf(i18n) ? "jsc-android-intl" : "jsc-android"`
`73`	`75`	`project.version = "${version}"`
`74`	`76`
	`77`	`+tasks.register('preparePrefabHeaders', Copy) {`
	`78`	`+ from("${headersDir}")`
	`79`	`+ filesMatching('*/.h') {`
	`80`	`+ path = "JavaScriptCore/${it.name}"`
	`81`	`+ }`
	`82`	`+ into(file("${prefabHeadersDir}"))`
	`83`	`+}`
	`84`	`+`
`75`	`85`	`afterEvaluate {`
	`86`	`+ preBuild.dependsOn(preparePrefabHeaders)`
	`87`	`+`
`76`	`88`	`publishing {`
`77`	`89`	`publications {`
`78`	`90`	`release(MavenPublication) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 31b634b

File tree

1 file changed

1 file changed

`‎lib/jsc-android/build.gradle‎`

0 commit comments