Commit 8dc9917

authored

feat: improved accessibility (#299)

* feat: add role attribute to InternalSegmentedOption for improved accessibility * fix: update role and aria attributes * test: update snapshot * chore: add @rc-component/np dependency and remove np package

1 parent bdc6c15 commit 8dc9917Copy full SHA for 8dc9917

File tree

3 files changed

+84

-43

lines changed

package.json
src
- index.tsx
tests/__snapshots__
- index.test.tsx.snap

3 files changed

+84

-43

lines changed

`‎package.json‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@`
`53`	`53`	`},`
`54`	`54`	`"devDependencies": {`
`55`	`55`	`"@rc-component/father-plugin": "^2.0.1",`
	`56`	`+ "@rc-component/np": "^1.0.0",`
`56`	`57`	`"@testing-library/jest-dom": "^5.16.5",`
`57`	`58`	`"@testing-library/react": "^14.2.1",`
`58`	`59`	`"@testing-library/user-event": "^14.5.2",`
`@@ -73,7 +74,6 @@`
`73`	`74`	`"jest": "^29.3.1",`
`74`	`75`	`"jest-environment-jsdom": "^29.3.1",`
`75`	`76`	`"less": "^3.10.3",`
`76`		`- "np": "^7.0.0",`
`77`	`77`	`"prettier": "^2.0.5",`
`78`	`78`	`"pretty-quick": "^3.0.0",`
`79`	`79`	`"react": "^18.0.0",`
`@@ -91,4 +91,4 @@`
`91`	`91`	`"tnpm": {`
`92`	`92`	`"mode": "npm"`
`93`	`93`	`}`
`94`		`-}`
	`94`	`+}`

`‎src/index.tsx‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,8 @@ const InternalSegmentedOption: React.FC<{`
`147`	`147`	`segmentedClassNames?.label,`
`148`	`148`	`)}`
`149`	`149`	`title={title}`
`150`		`- aria-selected={checked}`
	`150`	`+ role="radio"`
	`151`	`+ aria-checked={checked}`
`151`	`152`	`style={styles?.label}`
`152`	`153`	`>`
`153`	`154`	`{label}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 8dc9917

File tree

3 files changed

3 files changed

`‎package.json‎`

`‎src/index.tsx‎`

0 commit comments